From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753935AbdDKHno (ORCPT ); Tue, 11 Apr 2017 03:43:44 -0400 Received: from mx2.suse.de ([195.135.220.15]:43631 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733AbdDKHn2 (ORCPT ); Tue, 11 Apr 2017 03:43:28 -0400 Date: Tue, 11 Apr 2017 09:43:25 +0200 From: Petr Mladek To: Aleksey Makarov Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeep Holla , Greg Kroah-Hartman , Peter Hurley , Jiri Slaby , Robin Murphy , Steven Rostedt , "Nair, Jayachandran" , Sergey Senozhatsky Subject: Re: [PATCH v9 3/3] printk: fix double printing with earlycon Message-ID: <20170411074325.GC3452@pathway.suse.cz> References: <20170315102854.1763-1-aleksey.makarov@linaro.org> <20170405202006.18234-1-aleksey.makarov@linaro.org> <20170410142214.GA3452@pathway.suse.cz> <0514db53-4f8b-fa08-f461-902de85777ee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0514db53-4f8b-fa08-f461-902de85777ee@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 2017-04-10 21:00:35, Aleksey Makarov wrote: > > > On 04/10/2017 05:22 PM, Petr Mladek wrote: > >On Wed 2017-04-05 23:20:00, Aleksey Makarov wrote: > >>If a console was specified by ACPI SPCR table _and_ command line > >>parameters like "console=ttyAMA0" _and_ "earlycon" were specified, > >>then log messages appear twice. > >> > >>The root cause is that the code traverses the list of specified > >>consoles (the `console_cmdline` array) and stops at the first match. > >>But it may happen that the same console is referred by the elements > >>of this array twice: > >> > >> pl011,mmio,0x87e024000000,115200 -- from SPCR > >> ttyAMA0 -- from command line > >> > >>but in this case `preferred_console` points to the second entry and > >>the flag CON_CONSDEV is not set, so bootconsole is not deregistered. > >> > >>To fix that, introduce an invariant "The last non-braille console > >>is always the preferred one" on the entries of the console_cmdline > >>array. Then traverse it in reverse order to be sure that if > >>the console is preferred then it will be the first matching entry. > >>Introduce variable console_cmdline_cnt that keeps the number > >>of elements of the console_cmdline array (Petr Mladek). It helps > >>to get rid of the loop that searches for the end of this array. > >> > >>Reported-by: Sudeep Holla > >>Signed-off-by: Aleksey Makarov > > > >This version looks fine to me. Just a small nitpick below. > >Anyway: > > > >Reviewed-by: Petr Mladek > > Thank you for review. Can you (or anybody else) ACK it? > I am going to resend the whole series without those empty lines. > May I add your Acked-by:? Sure. Feel free to use: Acked-by: Petr Mladek The meaning of the tags is a bit unclear. Acked-by means that the maintainer agrees with the idea. But it does not necessarily means that she reviewed the code in details. I agree with the idea and did the review, so I used the Reviewed-by tag. Also you do not need to resend the patchset just because the two empty lines. Sergey agrees. I will wait day or two and push all three patches into the printk.git if nobody complains in the meantime. I could remove the two empty lines when doing so. Thanks a lot for the fix and patience. Best Regards, Petr