Re: [PATCH 11/12] grep: change the internal PCRE code & header names to be PCRE1

From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Jeffrey Walton" <noloader@gmail.com>,
	"Michał Kiedrowicz" <michal.kiedrowicz@gmail.com>,
	"J Smith" <dark.panda@gmail.com>,
	"Victor Leschuk" <vleschuk@gmail.com>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Brandon Williams" <bmwill@google.com>
Subject: Re: [PATCH 11/12] grep: change the internal PCRE code & header names to be PCRE1
Date: Tue, 11 Apr 2017 06:48:28 -0400	[thread overview]
Message-ID: <20170411104828.skkujde3qrvn4jrt@sigill.intra.peff.net> (raw)
In-Reply-To: <CACBZZX5V96Vv5NAYpkQSBWpn-4rgHOatAnL51o4-4DADAF+pEg@mail.gmail.com>

On Tue, Apr 11, 2017 at 12:45:55PM +0200, Ævar Arnfjörð Bjarmason wrote:

> On Tue, Apr 11, 2017 at 12:37 PM, Jeff King <peff@peff.net> wrote:
> > On Sat, Apr 08, 2017 at 01:25:05PM +0000, Ævar Arnfjörð Bjarmason wrote:
> >
> >> diff --git a/builtin/grep.c b/builtin/grep.c
> >> index 9478ab5dff..dffb9743b8 100644
> >> --- a/builtin/grep.c
> >> +++ b/builtin/grep.c
> >> @@ -490,7 +490,7 @@ static void compile_submodule_options(const struct grep_opt *opt,
> >>       case GREP_PATTERN_TYPE_FIXED:
> >>               argv_array_push(&submodule_options, "-F");
> >>               break;
> >> -     case GREP_PATTERN_TYPE_PCRE:
> >> +     case GREP_PATTERN_TYPE_PCRE1:
> >>               argv_array_push(&submodule_options, "-P");
> >>               break;
> >
> > Hmm. This isn't a problem yet, but wouldn't this need to pass some
> > pcre1-specific option instead of just "-P"?
> 
> Yes, this is a bug. I'll need to add a git_options along with
> submodule_options and pass -c grep.patternType=....

Maybe that's an indication we should have --pcre1-regexp and
--pcre2-regexp, so we don't have to resort to config tweaking.

-Peff