From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752545AbdDKNBs (ORCPT ); Tue, 11 Apr 2017 09:01:48 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:24309 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770AbdDKNBp (ORCPT ); Tue, 11 Apr 2017 09:01:45 -0400 Date: Tue, 11 Apr 2017 15:00:58 +0200 From: Daniel Kiper To: Juergen Gross Cc: Daniel Kiper , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, ptesarik@suse.com, eric.devolder@oracle.com, konrad.wilk@oracle.com, andrew.cooper3@citrix.com Subject: Re: [Xen-devel] [PATCH v2] xen, kdump: handle pv domain in paddr_vmcoreinfo_note() Message-ID: <20170411130058.GI4372@olila.local.net-space.pl> References: <20170331101438.28582-1-jgross@suse.com> <20170403124257.GA3439@router-fw-old.local.net-space.pl> <1df1de5c-8f89-3d65-b0cb-15a2a78992f8@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1df1de5c-8f89-3d65-b0cb-15a2a78992f8@suse.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 11, 2017 at 02:45:43PM +0200, Juergen Gross wrote: > On 03/04/17 14:42, Daniel Kiper wrote: > > On Fri, Mar 31, 2017 at 12:14:38PM +0200, Juergen Gross wrote: > >> For kdump to work correctly it needs the physical address of > >> vmcoreinfo_note. When running as dom0 this means the virtual address > >> has to be translated to the related machine address. > >> > >> paddr_vmcoreinfo_note() is meant to do the translation via > >> __pa_symbol() only, but being attributed "weak" it can be replaced > >> easily in Xen case. > >> > >> Signed-off-by: Juergen Gross > > > > Have you tested this patch with latest crash tool? Do dom0 and Xen > > hypervisor analysis work without any issue (at least basic commands > > like dmesg, bt, ps, etc.)? If yes for both you can add: > > > > Reviewed-by: Daniel Kiper > > So can I add your R-b: now? My R-b is still valid. Though, let's wait for Petr's Tested-by. He did makedumpfile tests but I asked him to do crash tool tests too. I think it is important. Daniel