From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752877AbdDKNa7 (ORCPT ); Tue, 11 Apr 2017 09:30:59 -0400 Received: from mail-qk0-f181.google.com ([209.85.220.181]:35838 "EHLO mail-qk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbdDKNa4 (ORCPT ); Tue, 11 Apr 2017 09:30:56 -0400 Date: Tue, 11 Apr 2017 09:30:53 -0400 From: Sean Paul To: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= Cc: dri-devel@lists.freedesktop.org, Dave Airlie , linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/udl: Fix unaligned memory access in udl_render_hline Message-ID: <20170411133053.stmwmsmjf7ybq42v@art_vandelay> References: <20170407200229.20642-1-j.neuschaefer@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170407200229.20642-1-j.neuschaefer@gmx.net> User-Agent: NeoMutt/20170306-66-6ddb52-dirty (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 07, 2017 at 10:02:29PM +0200, Jonathan Neuschäfer wrote: > On SPARC, the udl driver filled my kernel log with these messages: > > [186668.910612] Kernel unaligned access at TPC[76609c] udl_render_hline+0x13c/0x3a0 > > Use put_unaligned_be16 to avoid them. On x86 this results in the same > code, but on SPARC the compiler emits two single-byte stores. > Pushed to drm-misc-fixes with Dave's IRC Ack. Thanks, Sean > Signed-off-by: Jonathan Neuschäfer > --- > drivers/gpu/drm/udl/udl_transfer.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/udl/udl_transfer.c b/drivers/gpu/drm/udl/udl_transfer.c > index 917dcb978c2c..0c87b1ac6b68 100644 > --- a/drivers/gpu/drm/udl/udl_transfer.c > +++ b/drivers/gpu/drm/udl/udl_transfer.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > #include > #include "udl_drv.h" > @@ -163,7 +164,7 @@ static void udl_compress_hline16( > const u8 *const start = pixel; > const uint16_t repeating_pixel_val16 = pixel_val16; > > - *(uint16_t *)cmd = cpu_to_be16(pixel_val16); > + put_unaligned_be16(pixel_val16, cmd); > > cmd += 2; > pixel += bpp; > -- > 2.11.0 -- Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH] drm/udl: Fix unaligned memory access in udl_render_hline Date: Tue, 11 Apr 2017 09:30:53 -0400 Message-ID: <20170411133053.stmwmsmjf7ybq42v@art_vandelay> References: <20170407200229.20642-1-j.neuschaefer@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk0-x22f.google.com (mail-qk0-x22f.google.com [IPv6:2607:f8b0:400d:c09::22f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5838D6E562 for ; Tue, 11 Apr 2017 13:30:56 +0000 (UTC) Received: by mail-qk0-x22f.google.com with SMTP id p68so114096891qke.1 for ; Tue, 11 Apr 2017 06:30:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170407200229.20642-1-j.neuschaefer@gmx.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= Cc: Dave Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBBcHIgMDcsIDIwMTcgYXQgMTA6MDI6MjlQTSArMDIwMCwgSm9uYXRoYW4gTmV1c2No w6RmZXIgd3JvdGU6Cj4gT24gU1BBUkMsIHRoZSB1ZGwgZHJpdmVyIGZpbGxlZCBteSBrZXJuZWwg bG9nIHdpdGggdGhlc2UgbWVzc2FnZXM6Cj4gCj4gWzE4NjY2OC45MTA2MTJdIEtlcm5lbCB1bmFs aWduZWQgYWNjZXNzIGF0IFRQQ1s3NjYwOWNdIHVkbF9yZW5kZXJfaGxpbmUrMHgxM2MvMHgzYTAK PiAKPiBVc2UgcHV0X3VuYWxpZ25lZF9iZTE2IHRvIGF2b2lkIHRoZW0uIE9uIHg4NiB0aGlzIHJl c3VsdHMgaW4gdGhlIHNhbWUKPiBjb2RlLCBidXQgb24gU1BBUkMgdGhlIGNvbXBpbGVyIGVtaXRz IHR3byBzaW5nbGUtYnl0ZSBzdG9yZXMuCj4gCgpQdXNoZWQgdG8gZHJtLW1pc2MtZml4ZXMgd2l0 aCBEYXZlJ3MgSVJDIEFjay4KClRoYW5rcywKClNlYW4KCj4gU2lnbmVkLW9mZi1ieTogSm9uYXRo YW4gTmV1c2Now6RmZXIgPGoubmV1c2NoYWVmZXJAZ214Lm5ldD4KPiAtLS0KPiAgZHJpdmVycy9n cHUvZHJtL3VkbC91ZGxfdHJhbnNmZXIuYyB8IDMgKystCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL3VkbC91ZGxfdHJhbnNmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS91ZGwvdWRsX3RyYW5zZmVy LmMKPiBpbmRleCA5MTdkY2I5NzhjMmMuLjBjODdiMWFjNmI2OCAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vdWRsL3VkbF90cmFuc2Zlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Vk bC91ZGxfdHJhbnNmZXIuYwo+IEBAIC0xNCw2ICsxNCw3IEBACj4gICNpbmNsdWRlIDxsaW51eC9z bGFiLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9mYi5oPgo+ICAjaW5jbHVkZSA8bGludXgvcHJlZmV0 Y2guaD4KPiArI2luY2x1ZGUgPGFzbS91bmFsaWduZWQuaD4KPiAgCj4gICNpbmNsdWRlIDxkcm0v ZHJtUC5oPgo+ICAjaW5jbHVkZSAidWRsX2Rydi5oIgo+IEBAIC0xNjMsNyArMTY0LDcgQEAgc3Rh dGljIHZvaWQgdWRsX2NvbXByZXNzX2hsaW5lMTYoCj4gIAkJCWNvbnN0IHU4ICpjb25zdCBzdGFy dCA9IHBpeGVsOwo+ICAJCQljb25zdCB1aW50MTZfdCByZXBlYXRpbmdfcGl4ZWxfdmFsMTYgPSBw aXhlbF92YWwxNjsKPiAgCj4gLQkJCSoodWludDE2X3QgKiljbWQgPSBjcHVfdG9fYmUxNihwaXhl bF92YWwxNik7Cj4gKwkJCXB1dF91bmFsaWduZWRfYmUxNihwaXhlbF92YWwxNiwgY21kKTsKPiAg Cj4gIAkJCWNtZCArPSAyOwo+ICAJCQlwaXhlbCArPSBicHA7Cj4gLS0gCj4gMi4xMS4wCgotLSAK U2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==