From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752534AbdDKN6B (ORCPT ); Tue, 11 Apr 2017 09:58:01 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:38648 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbdDKN57 (ORCPT ); Tue, 11 Apr 2017 09:57:59 -0400 Date: Tue, 11 Apr 2017 14:57:55 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Aaro Koskinen , devicetree@vger.kernel.org, Rob Herring , Tony Lindgren , Mark Rutland Subject: Re: [PATCH v4 1/8] dt-bindings: mfd: Add retu/tahvo ASIC chips bindings Message-ID: <20170411135755.upbuxmathdbophov@dell> References: <20170404153036.6651-1-javier@osg.samsung.com> <20170404153036.6651-2-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170404153036.6651-2-javier@osg.samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 04 Apr 2017, Javier Martinez Canillas wrote: > There are Device Tree source files defining a device node for the > retu/tahvo I2C chip, but there isn't a DT binding document for it. > > Signed-off-by: Javier Martinez Canillas > > --- > > Changes in v4: > - Use "dt-bindings: mfd:" prefix in subject line (Rob Herring). > - Add information about what functions the device serve (Lee Jones). > - Avoid using MFD in Device Tree (Lee Jones). > > Changes in v3: None > Changes in v2: None > > Documentation/devicetree/bindings/mfd/retu.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/retu.txt For my own reference: Acked-for-MFD-by: Lee Jones > diff --git a/Documentation/devicetree/bindings/mfd/retu.txt b/Documentation/devicetree/bindings/mfd/retu.txt > new file mode 100644 > index 000000000000..7df21a2b28ea > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/retu.txt > @@ -0,0 +1,21 @@ > +* Device tree bindings for Nokia Retu and Tahvo multi-function device > + > +Retu and Tahvo are a multi-function devices found on Nokia Internet > +Tablets (770, N800 and N810). The Retu chip provides watchdog timer > +and power button control functionalities while Tahvo chip provides > +USB transceiver functionality. > + > +Required properties: > +- compatible: "nokia,retu" or "nokia,tahvo" > +- reg: Specifies the I2C slave address of the ASIC chip > + > +Example: > + > +i2c0 { > + retu: retu@1 { > + compatible = "nokia,retu"; > + interrupt-parent = <&gpio4>; > + interrupts = <12 IRQ_TYPE_EDGE_RISING>; > + reg = <0x1>; > + }; > +}; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog