* [PATCH] net/kni: remove unnecessary null check
@ 2017-04-11 14:33 Ferruh Yigit
2017-04-13 9:35 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Ferruh Yigit @ 2017-04-11 14:33 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev
Coverity issue: 1419721
Fixes: 75e2bc54c018 ("net/kni: add KNI PMD")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/kni/rte_eth_kni.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c
index 59205e7..ed4478e 100644
--- a/drivers/net/kni/rte_eth_kni.c
+++ b/drivers/net/kni/rte_eth_kni.c
@@ -489,12 +489,10 @@ eth_kni_remove(const char *name)
eth_kni_dev_stop(eth_dev);
- if (eth_dev->data) {
- internals = eth_dev->data->dev_private;
- rte_kni_release(internals->kni);
+ internals = eth_dev->data->dev_private;
+ rte_kni_release(internals->kni);
- rte_free(internals);
- }
+ rte_free(internals);
rte_free(eth_dev->data);
rte_eth_dev_release_port(eth_dev);
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/kni: remove unnecessary null check
2017-04-11 14:33 [PATCH] net/kni: remove unnecessary null check Ferruh Yigit
@ 2017-04-13 9:35 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-04-13 9:35 UTC (permalink / raw)
Cc: dev
On 4/11/2017 3:33 PM, Ferruh Yigit wrote:
> Coverity issue: 1419721
> Fixes: 75e2bc54c018 ("net/kni: add KNI PMD")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-13 9:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-11 14:33 [PATCH] net/kni: remove unnecessary null check Ferruh Yigit
2017-04-13 9:35 ` Ferruh Yigit
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.