From: Tony Lindgren <tony@atomide.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Marcel Partap <mpartap@gmx.net>,
Michael Scott <michael.scott@linaro.org>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode
Date: Tue, 11 Apr 2017 08:18:49 -0700 [thread overview]
Message-ID: <20170411151849.GI5339@atomide.com> (raw)
In-Reply-To: <4cd82ba4-435e-cffa-d152-98860716f38b@ti.com>
* Roger Quadros <rogerq@ti.com> [170411 00:31]:
> Hi Tony,
>
> On 11/04/17 03:15, Tony Lindgren wrote:
> > Commit 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
> > added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
> > bit the wrong way. The comments in the code are mostly correct, but the
> > inverted use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register
> > to be enabled instead of disabled like the comments say. And the
> > idle mode should be only disabled for UTMIAUTOIDLE while ULPIAUTOIDLE
> > can be enabled.
> >
> > This matches the TLL_CHANNEL_CONF_i register configuration for ehci-tll
> > in the Motorola Linux kernel tree for Wrigley 3G LTE modem on droid 4.
> > Without this patch the modem can only be pinged few times before it
> > stops responding. Also lsub -v output shows errors without this patch.
>
> This patch does 2 things.
> - Fixes the bad commit by correctly disabling Bitstuffing
> - Enables ULPI Autoidle.
>
> Is enabling ULPI autoidle required to fix the LTE modem issue? If not I'd put it
> in a separate patch.
No but it presumably saves some power. I'll resend as to patches.
Regards,
Tony
prev parent reply other threads:[~2017-04-11 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 0:15 [PATCH] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode Tony Lindgren
2017-04-11 7:28 ` Roger Quadros
2017-04-11 7:28 ` Roger Quadros
2017-04-11 15:18 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170411151849.GI5339@atomide.com \
--to=tony@atomide.com \
--cc=felipe.balbi@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=michael.scott@linaro.org \
--cc=mpartap@gmx.net \
--cc=rogerq@ti.com \
--cc=sameo@linux.intel.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.