All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yongjun <weiyj.lk@gmail.com>
To: Jiri Pirko <jiri@mellanox.com>,
	Arkadi Sharshevsky <arkadis@mellanox.com>,
	"David S. Miller" <davem@davemloft.net>
Cc: Wei Yongjun <weiyongjun1@huawei.com>, netdev@vger.kernel.org
Subject: [PATCH net-next v2] devlink: fix return value check in devlink_dpipe_header_put()
Date: Tue, 11 Apr 2017 16:02:02 +0000	[thread overview]
Message-ID: <20170411160202.17469-1-weiyj.lk@gmail.com> (raw)
In-Reply-To: <20170410131106.27683-1-weiyj.lk@gmail.com>

From: Wei Yongjun <weiyongjun1@huawei.com>

Fix the return value check which testing the wrong variable
in devlink_dpipe_header_put().

Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
---
v1 -> v2: fix  a typo in patch comment
---
 net/core/devlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/devlink.c b/net/core/devlink.c
index 24b7660..0afac58 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -2031,7 +2031,7 @@ static int devlink_dpipe_header_put(struct sk_buff *skb,
 	int err;
 
 	header_attr = nla_nest_start(skb, DEVLINK_ATTR_DPIPE_HEADER);
-	if (!header)
+	if (!header_attr)
 		return -EMSGSIZE;
 
 	if (nla_put_string(skb, DEVLINK_ATTR_DPIPE_HEADER_NAME, header->name) ||

  parent reply	other threads:[~2017-04-11 16:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-10 13:11 [PATCH net-next] devlink: fix return value check in devlink_dpipe_header_put() Wei Yongjun
2017-04-11  6:39 ` Jiri Pirko
2017-04-11 16:02 ` Wei Yongjun [this message]
2017-04-11 18:53   ` [PATCH net-next v2] " David Miller
2017-04-12  3:03 ` [PATCH net-next] " David Miller
2017-04-12  3:30   ` weiyongjun (A)
2017-04-12 14:19     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170411160202.17469-1-weiyj.lk@gmail.com \
    --to=weiyj.lk@gmail.com \
    --cc=arkadis@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=jiri@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.