From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v3 net-next RFC] Generic XDP Date: Wed, 12 Apr 2017 21:55:12 -0400 (EDT) Message-ID: <20170412.215512.844254291088810993.davem@davemloft.net> References: <20170412.145415.1441440342830198148.davem@davemloft.net> <20170412143037.5fd7a088@xeon-e3> <1492033793.10587.73.camel@edumazet-glaptop3.roam.corp.google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: stephen@networkplumber.org, netdev@vger.kernel.org, xdp-newbies@vger.kernel.org To: eric.dumazet@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:53062 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755548AbdDMBzN (ORCPT ); Wed, 12 Apr 2017 21:55:13 -0400 In-Reply-To: <1492033793.10587.73.camel@edumazet-glaptop3.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Wed, 12 Apr 2017 14:49:53 -0700 > On Wed, 2017-04-12 at 14:30 -0700, Stephen Hemminger wrote: >> On Wed, 12 Apr 2017 14:54:15 -0400 (EDT) >> David Miller wrote: >> >> > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >> > index b0aa089..071a58b 100644 >> > --- a/include/linux/netdevice.h >> > +++ b/include/linux/netdevice.h >> > @@ -1891,9 +1891,17 @@ struct net_device { >> > struct lock_class_key *qdisc_tx_busylock; >> > struct lock_class_key *qdisc_running_key; >> > bool proto_down; >> > + struct bpf_prog __rcu *xdp_prog; >> >> It would be good if all devices could reuse this for the xdp_prog pointer. >> It would allow for could be used for introspection utility functions in future. > > Problem is that some xdp usages were envisioning a per RX queue xdp > program. True, but that hasn't materialized yet so designing for it so soon doesn't make a lot of sense.