From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs_db: allow write -d to dqblks
Date: Tue, 11 Apr 2017 23:11:04 -0700 [thread overview]
Message-ID: <20170412061103.GK8502@birch.djwong.org> (raw)
In-Reply-To: <4e5eaa1f-b551-885b-6d1c-e90f985496be@sandeen.net>
On Tue, Apr 11, 2017 at 10:45:27PM -0500, Eric Sandeen wrote:
> Allow write -d to write bad data and recalculate CRC
> for dqblks.
>
> Inspired-by: Darrick J. Wong <darrick.wong@oracle.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>
> diff --git a/db/io.c b/db/io.c
> index 67ed5f9..9918a51 100644
> --- a/db/io.c
> +++ b/db/io.c
> @@ -476,6 +476,17 @@ xfs_verify_recalc_inode_crc(
> }
>
> void
> +xfs_verify_recalc_dquot_crc(
> + struct xfs_buf *bp)
> +{
> + ASSERT((iocur_top->dquot_buf));
> + ASSERT(iocur_top->bp == bp);
> +
> + xfs_update_cksum(iocur_top->data, sizeof(struct xfs_dqblk),
> + XFS_DQUOT_CRC_OFF);
> +}
> +
> +void
> xfs_verify_recalc_crc(
> struct xfs_buf *bp)
> {
> diff --git a/db/io.h b/db/io.h
> index 12d96c2..b415b82 100644
> --- a/db/io.h
> +++ b/db/io.h
> @@ -65,6 +65,7 @@ extern void ring_add(void);
> extern void set_iocur_type(const struct typ *t);
> extern void xfs_dummy_verify(struct xfs_buf *bp);
> extern void xfs_verify_recalc_inode_crc(struct xfs_buf *bp);
> +extern void xfs_verify_recalc_dquot_crc(struct xfs_buf *bp);
> extern void xfs_verify_recalc_crc(struct xfs_buf *bp);
>
> /*
> diff --git a/db/write.c b/db/write.c
> index 70c9865..d24ea05 100644
> --- a/db/write.c
> +++ b/db/write.c
> @@ -139,7 +139,8 @@ write_f(
>
> if (invalid_data &&
> iocur_top->typ->crc_off == TYP_F_NO_CRC_OFF &&
> - !iocur_top->ino_buf) {
> + !iocur_top->ino_buf &&
> + !iocur_top->dquot_buf) {
> dbprintf(_("Cannot recalculate CRCs on this type of object\n"));
> return 0;
> }
> @@ -169,6 +170,9 @@ write_f(
> } else if (iocur_top->ino_buf) {
> local_ops.verify_write = xfs_verify_recalc_inode_crc;
> dbprintf(_("Allowing write of corrupted inode with good CRC\n"));
> + } else if (iocur_top->dquot_buf) {
> + local_ops.verify_write = xfs_verify_recalc_dquot_crc;
> + dbprintf(_("Allowing write of corrupted dquot with good CRC\n"));
> } else { /* invalid data */
> local_ops.verify_write = xfs_verify_recalc_crc;
> dbprintf(_("Allowing write of corrupted data with good CRC\n"));
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-12 6:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 22:53 [PATCH] xfs_db: allow write -d to inodes Darrick J. Wong
2017-04-12 2:09 ` Eric Sandeen
2017-04-12 2:58 ` Eric Sandeen
2017-04-12 6:11 ` Darrick J. Wong
2017-04-12 3:45 ` [PATCH] xfs_db: allow write -d to dqblks Eric Sandeen
2017-04-12 6:11 ` Darrick J. Wong [this message]
2017-04-12 3:54 ` [PATCH] xfs_db: set buf flag for inode or dqblk with "type" Eric Sandeen
2017-04-12 6:07 ` Darrick J. Wong
2017-04-12 12:35 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412061103.GK8502@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.