From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753341AbdDLIR2 (ORCPT ); Wed, 12 Apr 2017 04:17:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33670 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbdDLIRZ (ORCPT ); Wed, 12 Apr 2017 04:17:25 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9B2E34E4EE Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9B2E34E4EE Date: Wed, 12 Apr 2017 10:17:21 +0200 From: Jiri Olsa To: David Carrillo-Cisneros Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Andi Kleen , Simon Que , Wang Nan , Jiri Olsa , He Kuang , Masami Hiramatsu , Stephane Eranian , Paul Turner Subject: Re: [PATCH 4/6] perf report: hint .perfconfig error when invalid sorting key Message-ID: <20170412081721.GC17517@krava> References: <20170412064919.92449-1-davidcc@google.com> <20170412064919.92449-6-davidcc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170412064919.92449-6-davidcc@google.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 12 Apr 2017 08:17:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 11, 2017 at 11:49:17PM -0700, David Carrillo-Cisneros wrote: > My fat-fingering of sort keys in .perfconfig was a common cause of > perf report silently terminating without apparent error. > > This was because 1) error in setup_sorting in cmd_report was ignored > and 2) no message was log in UI browser that would prevent UI from > exit before user prompt. Fix both. there's UI init ahead of this code.. I had to move it below your code to spot any error message there's other errors further on.. perhaps we should move it even further ;-) or cancel the ui before the error is printed jirka --- diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 19a69ca0e9c9..abcf3aadca9e 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -982,11 +982,6 @@ int cmd_report(int argc, const char **argv) if (report.header || report.header_only || report.show_threads) use_browser = 0; - if (strcmp(input_name, "-") != 0) - setup_browser(true); - else - use_browser = 0; - ret = setup_sorting(session->evlist); if (ret < 0) { if (sort_order) @@ -999,6 +994,11 @@ int cmd_report(int argc, const char **argv) goto error; } + if (strcmp(input_name, "-") != 0) + setup_browser(true); + else + use_browser = 0; + if ((report.header || report.header_only) && !quiet) { perf_session__fprintf_info(session, stdout, report.show_full_info);