From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 40/53] genromfs: use $(HOST_DIR) instead of $(HOST_DIR)/usr as prefix
Date: Wed, 12 Apr 2017 11:39:14 +0200 [thread overview]
Message-ID: <20170412093928.1006-41-arnout@mind.be> (raw)
In-Reply-To: <20170412093928.1006-1-arnout@mind.be>
genromfs is special because it uses "PREFIX" in the meaning of DESTDIR
and "prefix" in the meaning of prefix. We were up to know using it
incorrectly for host: PREFIX shouldn't be set and only prefix should
be set.
Add an explanatory comment for this unusual behaviour.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/genromfs/genromfs.mk | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/genromfs/genromfs.mk b/package/genromfs/genromfs.mk
index 3025550637..fd696b45b2 100644
--- a/package/genromfs/genromfs.mk
+++ b/package/genromfs/genromfs.mk
@@ -16,6 +16,8 @@ define GENROMFS_BUILD_CMDS
LDFLAGS="$(TARGET_LDFLAGS)"
endef
+# "PREFIX" is the equivalent of DESTDIR in autotools, "prefix" is the
+# traditional prefix. "prefix" defaults to /usr so no need to set it.
define GENROMFS_INSTALL_TARGET_CMDS
$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) PREFIX=$(TARGET_DIR) install
endef
@@ -25,7 +27,7 @@ define HOST_GENROMFS_BUILD_CMDS
endef
define HOST_GENROMFS_INSTALL_CMDS
- $(HOST_MAKE_ENV) $(MAKE) -C $(@D) PREFIX=$(HOST_DIR) install
+ $(HOST_MAKE_ENV) $(MAKE) -C $(@D) prefix=$(HOST_DIR) install
endef
$(eval $(generic-package))
--
2.11.0
next prev parent reply other threads:[~2017-04-12 9:39 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 9:38 [Buildroot] [PATCH 00/53] Eliminate $(HOST_DIR)/usr Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 01/53] pkg-rebar: remove redundant / in front of $($(PKG)_ERLANG_LIBDIR) Arnout Vandecappelle
2017-04-12 9:46 ` Thomas Petazzoni
2017-04-12 10:55 ` Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 02/53] libsepol: rework host installation Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 03/53] Move $(HOST_DIR)/usr/$(GNU_TARGET_NAME) one level up Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 04/53] Move $(HOST_DIR)/usr/lib to $(HOST_DIR)/lib Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 05/53] Eliminate $(HOST_DIR)/usr Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 06/53] check-host-rpath: no longer check $(HOST_DIR)/usr/{bin, sbin} Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 07/53] Makefile: remove $(HOST_DIR)/usr from BR_PATH Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 08/53] package/Makefile.in: remove $(HOST_DIR)/usr part from HOST_LDFLAGS Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 09/53] gdb: Remove /usr part from installation path of gdbserver Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 10/53] gcc-final: things are no longer installed in $(HOST_DIR)/usr Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 11/53] pkg-autotools: use $(HOST_DIR) instead of $(HOST_DIR)/usr as prefix Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 12/53] pkg-cmake: " Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 13/53] pkg-cmake: move configuration files out of $(HOST_DIR)/usr Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 14/53] pkg-cmake: programs are now installed in $(HOST_DIR)/bin Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 15/53] pkg-python: use $(HOST_DIR) instead of $(HOST_DIR)/usr as prefix Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 16/53] pkg-rebar: " Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 17/53] generic packages: " Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 18/53] Globally replace $(HOST_DIR)/usr/bin with $(HOST_DIR)/bin Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 19/53] Globally replace $(HOST_DIR)/usr/sbin with $(HOST_DIR)/sbin Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 20/53] Globally replace $(HOST_DIR)/usr/lib with $(HOST_DIR)/lib Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 21/53] Globally replace $(HOST_DIR)/usr/include with $(HOST_DIR)/include Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 22/53] Globally replace $(HOST_DIR)/usr/share with $(HOST_DIR)/share Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 23/53] Globally replace $(HOST_DIR)/usr with $(HOST_DIR) Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 24/53] luarocks: things are no longer installed in $(HOST_DIR)/usr Arnout Vandecappelle
2017-04-12 9:38 ` [Buildroot] [PATCH 25/53] qt: " Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 26/53] boards: replace $HOST_DIR/usr/ with $HOST_DIR/ in scripts Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 27/53] chromebook snow: remove $(HOST_DIR)/usr reference from README Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 28/53] warpboard: " Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 29/53] stm32f429-disco: replace $HOST_DIR/usr with $HOST_DIR in flash script Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 30/53] stm32f469-disco: " Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 31/53] eclipse-register-toolchain: toolchain is no longer installed in $(HOST_DIR)/usr Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 32/53] manual: remove references to host/usr paths Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 33/53] grub2: remove host/usr reference from help text Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 34/53] lttng-tools: " Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 35/53] mfgtools: remove host/usr reference from readme.txt Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 36/53] lesstif: remove host/usr reference from .mk comment Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 37/53] board/gdb/bfin-bf512: remove host/usr reference from readme.txt Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 38/53] board/csky: " Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 39/53] libffi: avoid $(HOST_DIR)/usr while moving headers Arnout Vandecappelle
2017-04-12 9:39 ` Arnout Vandecappelle [this message]
2017-04-12 9:39 ` [Buildroot] [PATCH 41/53] libcap: use $(HOST_DIR) as prefix instead of DESTDIR Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 42/53] lzip: " Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 43/53] opkg-utils: use $(HOST_DIR) as PREFIX " Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 44/53] raspberrypi-usbboot: remove /usr from DESTDIR-based install commands Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 45/53] dos2unix: use prefix instead of DESTDIR for host installation Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 46/53] imx-uxb-loader: " Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 47/53] mtd: use PREFIX " Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 48/53] grub2: install in $(HOST_DIR) instead of $(HOST_DIR)/usr Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 49/53] sepolgen: strip /usr/ part from HOST_DIR Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 50/53] libsemanage: rework host installation Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 51/53] libselinux: " Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 52/53] checkpolicy: " Arnout Vandecappelle
2017-04-12 9:39 ` [Buildroot] [PATCH 53/53] policycoreutils: " Arnout Vandecappelle
2017-04-18 21:49 ` [Buildroot] [PATCH 00/53] Eliminate $(HOST_DIR)/usr Arnout Vandecappelle
2017-07-02 13:54 ` Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412093928.1006-41-arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.