From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:36749 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752668AbdDLJwI (ORCPT ); Wed, 12 Apr 2017 05:52:08 -0400 Date: Wed, 12 Apr 2017 11:52:05 +0200 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org Subject: Re: [PATCH 21/25] nfs: Convert to separately allocated bdi Message-ID: <20170412095205.GC11138@quack2.suse.cz> References: <20170329105623.18241-1-jack@suse.cz> <20170329105623.18241-22-jack@suse.cz> <20170412082034.GU9830@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170412082034.GU9830@infradead.org> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Wed 12-04-17 01:20:34, Christoph Hellwig wrote: > > /* > > * Finish setting up an NFS2/3 superblock > > */ > > I was just looking why you didn't update the v4 variant, but it seems > like the comment above is simply incorrect.. Yes, it's used for NFS4 as well AFAICT. > Thus the patch looks fine: > > Reviewed-by: Christoph Hellwig Thanks. Honza -- Jan Kara SUSE Labs, CR