From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9147B21A04823 for ; Tue, 11 Apr 2017 17:43:39 -0700 (PDT) Date: Wed, 12 Apr 2017 10:43:37 +1000 From: Stephen Rothwell Subject: Re: [PATCH 6/9] powerpc, mm: Enable ZONE_DEVICE on powerpc Message-ID: <20170412104337.535c5abb@canb.auug.org.au> In-Reply-To: <20170411174233.21902-7-oohall@gmail.com> References: <20170411174233.21902-1-oohall@gmail.com> <20170411174233.21902-7-oohall@gmail.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Oliver O'Halloran Cc: linuxppc-dev@lists.ozlabs.org, arbab@linux.vnet.ibm.com, linux-nvdimm@lists.01.org List-ID: Hi Oliver, On Wed, 12 Apr 2017 03:42:30 +1000 Oliver O'Halloran wrote: > > Flip the switch. Running around and screaming "IT'S ALIVE" is optional, > but recommended. > > Signed-off-by: Oliver O'Halloran > --- > mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 43d000e44424..d696af58f97f 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -724,7 +724,7 @@ config ZONE_DEVICE > depends on MEMORY_HOTPLUG > depends on MEMORY_HOTREMOVE > depends on SPARSEMEM_VMEMMAP > - depends on X86_64 #arch_add_memory() comprehends device memory > + depends on (X86_64 || PPC_BOOK3S_64) #arch_add_memory() comprehends device memory > That's fine, but at what point do we create CONFIG_ARCH_HAVE_ZONE_DEVICE, replace the "depends on " above with "depends on ARCH_HAVE_ZONE_DEVICE" and select that from the appropriate places? -- Cheers, Stephen Rothwell _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3w2lXV1jRfzDq5W for ; Wed, 12 Apr 2017 10:43:38 +1000 (AEST) Date: Wed, 12 Apr 2017 10:43:37 +1000 From: Stephen Rothwell To: Oliver O'Halloran Cc: linuxppc-dev@lists.ozlabs.org, arbab@linux.vnet.ibm.com, linux-nvdimm@lists.01.org Subject: Re: [PATCH 6/9] powerpc, mm: Enable ZONE_DEVICE on powerpc Message-ID: <20170412104337.535c5abb@canb.auug.org.au> In-Reply-To: <20170411174233.21902-7-oohall@gmail.com> References: <20170411174233.21902-1-oohall@gmail.com> <20170411174233.21902-7-oohall@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Oliver, On Wed, 12 Apr 2017 03:42:30 +1000 Oliver O'Halloran wrote: > > Flip the switch. Running around and screaming "IT'S ALIVE" is optional, > but recommended. > > Signed-off-by: Oliver O'Halloran > --- > mm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/Kconfig b/mm/Kconfig > index 43d000e44424..d696af58f97f 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -724,7 +724,7 @@ config ZONE_DEVICE > depends on MEMORY_HOTPLUG > depends on MEMORY_HOTREMOVE > depends on SPARSEMEM_VMEMMAP > - depends on X86_64 #arch_add_memory() comprehends device memory > + depends on (X86_64 || PPC_BOOK3S_64) #arch_add_memory() comprehends device memory > That's fine, but at what point do we create CONFIG_ARCH_HAVE_ZONE_DEVICE, replace the "depends on " above with "depends on ARCH_HAVE_ZONE_DEVICE" and select that from the appropriate places? -- Cheers, Stephen Rothwell