From: Matthew Auld <matthew.william.auld@gmail.com>
To: Robert Bragg <robert@sixbynine.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 7/7] drm/i915/perf: remove perf.hook_lock
Date: Wed, 12 Apr 2017 12:36:00 +0100 [thread overview]
Message-ID: <20170412113600.e4vadpeoklpvreve@mwahaha> (raw)
In-Reply-To: <20170405162320.30094-8-robert@sixbynine.org>
On 04/05, Robert Bragg wrote:
> In earlier iterations of the i915-perf driver we had a number of
> callbacks/hooks from other parts of the i915 driver to e.g. notify us
> when a legacy context was pinned and these could run asynchronously with
> respect to the stream file operations and might also run in atomic
> context.
>
> dev_priv->perf.hook_lock had been for serialising access to state needed
> within these callbacks, but as the code has evolved some of the hooks
> have gone away or are implemented to avoid needing to lock any state.
>
> The remaining use of this lock was actually redundant considering how
> the gen7 oacontrol state used to be updated as part of a context pin
> hook.
>
> Signed-off-by: Robert Bragg <robert@sixbynine.org>
Thanks for following up with a patch.
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-04-12 11:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 16:23 [PATCH v3 0/7] Enable OA unit for Gen 8 and 9 in i915 perf Robert Bragg
2017-04-05 16:23 ` [PATCH v3 1/7] drm/i915: expose _SLICE_MASK GETPARM Robert Bragg
2017-04-05 16:23 ` [PATCH v3 2/7] drm/i915: expose _SUBSLICE_MASK GETPARM Robert Bragg
2017-04-05 16:23 ` [PATCH v3 3/7] drm/i915/perf: Add 'render basic' Gen8+ OA unit configs Robert Bragg
2017-04-05 16:23 ` [PATCH v3 4/7] drm/i915/perf: Add OA unit support for Gen 8+ Robert Bragg
2017-04-06 16:56 ` Lionel Landwerlin
2017-04-12 11:33 ` Matthew Auld
2017-04-12 14:57 ` Robert Bragg
2017-04-05 16:23 ` [PATCH v3 5/7] drm/i915/perf: Add more OA configs for BDW, CHV, SKL + BXT Robert Bragg
2017-04-05 16:23 ` [PATCH v3 6/7] drm/i915/perf: per-gen timebase for checking sample freq Robert Bragg
2017-04-05 16:49 ` Lionel Landwerlin
2017-04-05 17:06 ` Ville Syrjälä
2017-04-05 17:17 ` Lionel Landwerlin
2017-04-05 17:26 ` Ville Syrjälä
2017-04-05 17:59 ` Robert Bragg
2017-04-05 19:05 ` [PATCH v2] " Robert Bragg
2017-04-12 12:34 ` Matthew Auld
2017-04-12 15:07 ` Robert Bragg
2017-04-05 16:23 ` [PATCH v3 7/7] drm/i915/perf: remove perf.hook_lock Robert Bragg
2017-04-12 11:36 ` Matthew Auld [this message]
2017-04-05 16:42 ` ✓ Fi.CI.BAT: success for Enable OA unit for Gen 8 and 9 in i915 perf (rev4) Patchwork
2017-04-05 19:21 ` ✓ Fi.CI.BAT: success for Enable OA unit for Gen 8 and 9 in i915 perf (rev5) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170412113600.e4vadpeoklpvreve@mwahaha \
--to=matthew.william.auld@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=robert@sixbynine.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.