From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2] eal: redefine logtype values Date: Wed, 12 Apr 2017 14:41:11 -0700 Message-ID: <20170412144111.2d6bb7d8@xeon-e3> References: <1492006471-114636-1-git-send-email-pablo.de.lara.guarch@intel.com> <1492011332-5846-1-git-send-email-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: olivier.matz@6wind.com, thomas.monjalon@6wind.com, dev@dpdk.org To: Pablo de Lara Return-path: Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 2ECC72C27 for ; Wed, 12 Apr 2017 23:41:14 +0200 (CEST) Received: by mail-pf0-f178.google.com with SMTP id s16so19440189pfs.0 for ; Wed, 12 Apr 2017 14:41:14 -0700 (PDT) In-Reply-To: <1492011332-5846-1-git-send-email-pablo.de.lara.guarch@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 12 Apr 2017 16:35:32 +0100 Pablo de Lara wrote: > + /* register legacy log types */ > + __rte_log_register("eal", RTE_LOGTYPE_EAL); > + __rte_log_register("malloc", RTE_LOGTYPE_MALLOC); > + __rte_log_register("ring", RTE_LOGTYPE_RING); > + __rte_log_register("mempool", RTE_LOGTYPE_MEMPOOL); > + __rte_log_register("timer", RTE_LOGTYPE_TIMER); > + __rte_log_register("pmd", RTE_LOGTYPE_PMD); > + __rte_log_register("hash", RTE_LOGTYPE_HASH); > + __rte_log_register("lpm", RTE_LOGTYPE_LPM); > + __rte_log_register("kni", RTE_LOGTYPE_KNI); > + __rte_log_register("acl", RTE_LOGTYPE_ACL); > + __rte_log_register("power", RTE_LOGTYPE_POWER); > + __rte_log_register("meter", RTE_LOGTYPE_METER); > + __rte_log_register("sched", RTE_LOGTYPE_SCHED); > + __rte_log_register("port", RTE_LOGTYPE_PORT); > + __rte_log_register("table", RTE_LOGTYPE_TABLE); > + __rte_log_register("pipeline", RTE_LOGTYPE_PIPELINE); > + __rte_log_register("mbuf", RTE_LOGTYPE_MBUF); > + __rte_log_register("cryptodev", RTE_LOGTYPE_CRYPTODEV); > + __rte_log_register("efd", RTE_LOGTYPE_EFD); > + __rte_log_register("eventdev", RTE_LOGTYPE_EVENTDEV); > + __rte_log_register("user1", RTE_LOGTYPE_USER1); > + __rte_log_register("user2", RTE_LOGTYPE_USER2); > + __rte_log_register("user3", RTE_LOGTYPE_USER3); > + __rte_log_register("user4", RTE_LOGTYPE_USER4); > + __rte_log_register("user5", RTE_LOGTYPE_USER5); > + __rte_log_register("user6", RTE_LOGTYPE_USER6); > + __rte_log_register("user7", RTE_LOGTYPE_USER7); > + __rte_log_register("user8", RTE_LOGTYPE_USER8); Why is this not a table rather than code? Data driven design is better.