From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyLOE-0000V7-JK for qemu-devel@nongnu.org; Wed, 12 Apr 2017 12:45:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyLOD-0000Xn-UX for qemu-devel@nongnu.org; Wed, 12 Apr 2017 12:45:06 -0400 From: "Daniel P. Berrange" Date: Wed, 12 Apr 2017 17:44:43 +0100 Message-Id: <20170412164445.23039-3-berrange@redhat.com> In-Reply-To: <20170412164445.23039-1-berrange@redhat.com> References: <20170412164445.23039-1-berrange@redhat.com> Subject: [Qemu-devel] [PATCH v4 2/4] qemu-img: fix --image-opts usage with dd command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Max Reitz , Eric Blake , Fam Zheng , "Daniel P. Berrange" The --image-opts flag can only be used to affect the parsing of the source image. The target image has to be specified in the traditional style regardless, since it needs to be passed to the bdrv_create() API which does not support the new style opts. Reviewed-by: Max Reitz Signed-off-by: Daniel P. Berrange --- qemu-img.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 2249c21..83aff5e 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -4312,8 +4312,13 @@ static int img_dd(int argc, char **argv) goto out; } - blk2 = img_open(image_opts, out.filename, out_fmt, BDRV_O_RDWR, - false, false); + /* TODO, we can't honour --image-opts for the target, + * since it needs to be given in a format compatible + * with the bdrv_create() call above which does not + * support image-opts style. + */ + blk2 = img_open_file(out.filename, out_fmt, BDRV_O_RDWR, + false, false); if (!blk2) { ret = -1; -- 2.9.3