From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v2] net/vhost: stop dev in close and address mem leak Date: Thu, 13 Apr 2017 09:45:42 +0800 Message-ID: <20170413014542.GD7333@yliu-dev.sh.intel.com> References: <20170406055112.GQ18844@yliu-dev.sh.intel.com> <1491524797-27299-1-git-send-email-sabhang@brocade.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: mtetsuyah@gmail.com, dev@dpdk.org To: Sagar Abhang Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 9244D2C23 for ; Thu, 13 Apr 2017 03:48:37 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1491524797-27299-1-git-send-email-sabhang@brocade.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 06, 2017 at 05:26:37PM -0700, Sagar Abhang wrote: > Move the call to stop the device inside the close routine because close > needs to stop the device if it isn't stopped. > > Free the allocated queue buffers in close instead of doing so in remove. > Original code had these clean ups in remove which was causing memory > leak. > > Signed-off-by: Sagar Abhang Applied to dpdk-next-virtio. --yliu