All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: Joe Perches <joe@perches.com>
Cc: Gavin Shan <gwshan@linux.vnet.ibm.com>,
	netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next 4/8] net/ncsi: Add debugging infrastructurre
Date: Thu, 13 Apr 2017 15:11:12 +1000	[thread overview]
Message-ID: <20170413051112.GA28206@gwshan> (raw)
In-Reply-To: <1492057706.28586.10.camel@perches.com>

On Wed, Apr 12, 2017 at 09:28:26PM -0700, Joe Perches wrote:
>On Thu, 2017-04-13 at 12:46 +1000, Gavin Shan wrote:
>> This creates procfs directories as NCSI debugging infrastructure.
>> With the patch applied, We will see below procfs directories. Every
>> NCSI package and channel has one corresponding directory. Other than
>> presenting the NCSI topology, No real function has been achieved
>> through these procfs directories so far.
>
>/proc is meant to be stable.
>
>Why not use debugfs?
>

Joe, thanks for the comment. I think debugfs makes more sense than
procfs in this case. I will use it in next respin. The directory
structure won't change, meaning /sys/kernel/debug/ncsi/ will be
created.

>>      /proc/ncsi/eth0
>>      /proc/ncsi/eth0/p0
>>      /proc/ncsi/eth0/p0/c0
>>      /proc/ncsi/eth0/p0/c1
>

Thanks,
Gavin

  reply	other threads:[~2017-04-13  5:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-13  2:46 [PATCH net-next 0/8] net/ncsi: Add debugging functionality Gavin Shan
2017-04-13  2:46 ` [PATCH net-next 1/8] net/ncsi: Disable HWA mode when no channels are found Gavin Shan
2017-04-13  2:46 ` [PATCH net-next 2/8] net/ncsi: Properly track channel monitor timer state Gavin Shan
2017-04-13  2:46 ` [PATCH net-next 3/8] net/ncsi: Enforce failover on link monitor timeout Gavin Shan
2017-04-13  2:46 ` [PATCH net-next 4/8] net/ncsi: Add debugging infrastructurre Gavin Shan
2017-04-13  4:28   ` Joe Perches
2017-04-13  5:11     ` Gavin Shan [this message]
2017-04-13  2:46 ` [PATCH net-next 5/8] net/ncsi: Dump NCSI packet statistics Gavin Shan
2017-04-13  2:46 ` [PATCH net-next 6/8] net/ncsi: Support NCSI packet generation Gavin Shan
2017-04-13  2:46 ` [PATCH net-next 7/8] net/ncsi: No error report on DP response to non-existing package Gavin Shan
2017-04-13  2:46 ` [PATCH net-next 8/8] net/ncsi: Fix length of GVI response packet Gavin Shan
2017-04-13  7:57 ` [PATCH net-next 0/8] net/ncsi: Add debugging functionality Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170413051112.GA28206@gwshan \
    --to=gwshan@linux.vnet.ibm.com \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.