* [Qemu-devel] [PATCH] progress: Show current progress on SIGINFO
@ 2017-02-07 23:57 Max Reitz
2017-02-13 14:29 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Max Reitz @ 2017-02-07 23:57 UTC (permalink / raw)
To: qemu-block; +Cc: qemu-devel, Max Reitz, Kevin Wolf
Currently we only print progress information on retrieval of SIGUSR1.
Some systems have a dedicated SIGINFO for this, however, so it should be
handled appropriately if it is available.
Buglink: https://bugs.launchpad.net/qemu/+bug/1662468
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
Can anyone test this on a BSD system? O:-)
---
util/qemu-progress.c | 3 +++
qemu-img.texi | 3 ++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/util/qemu-progress.c b/util/qemu-progress.c
index f745233763..3c2223c1a2 100644
--- a/util/qemu-progress.c
+++ b/util/qemu-progress.c
@@ -88,6 +88,9 @@ static void progress_dummy_init(void)
action.sa_handler = sigusr_print;
action.sa_flags = 0;
sigaction(SIGUSR1, &action, NULL);
+#ifdef SIGINFO
+ sigaction(SIGINFO, &action, NULL);
+#endif
/*
* SIGUSR1 is SIG_IPI and gets blocked in qemu_init_main_loop(). In the
diff --git a/qemu-img.texi b/qemu-img.texi
index 174aae38b7..b7e849b22b 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -84,7 +84,8 @@ with or without a command shows help and lists the supported formats
@item -p
display progress bar (compare, convert and rebase commands only).
If the @var{-p} option is not used for a command that supports it, the
-progress is reported when the process receives a @code{SIGUSR1} signal.
+progress is reported when the process receives a @code{SIGUSR1} or
+@code{SIGINFO} signal.
@item -q
Quiet mode - do not print any output (except errors). There's no progress bar
in case both @var{-q} and @var{-p} options are used.
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] progress: Show current progress on SIGINFO
2017-02-07 23:57 [Qemu-devel] [PATCH] progress: Show current progress on SIGINFO Max Reitz
@ 2017-02-13 14:29 ` Stefan Hajnoczi
2017-03-18 2:34 ` [Qemu-devel] " Max Reitz
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Stefan Hajnoczi @ 2017-02-13 14:29 UTC (permalink / raw)
To: Max Reitz; +Cc: qemu-block, Kevin Wolf, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
On Wed, Feb 08, 2017 at 12:57:57AM +0100, Max Reitz wrote:
> Currently we only print progress information on retrieval of SIGUSR1.
> Some systems have a dedicated SIGINFO for this, however, so it should be
> handled appropriately if it is available.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1662468
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> Can anyone test this on a BSD system? O:-)
> ---
> util/qemu-progress.c | 3 +++
> qemu-img.texi | 3 ++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] progress: Show current progress on SIGINFO
2017-02-07 23:57 [Qemu-devel] [PATCH] progress: Show current progress on SIGINFO Max Reitz
2017-02-13 14:29 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
@ 2017-03-18 2:34 ` Max Reitz
2017-04-13 20:38 ` Max Reitz
2017-04-28 16:48 ` Max Reitz
3 siblings, 0 replies; 7+ messages in thread
From: Max Reitz @ 2017-03-18 2:34 UTC (permalink / raw)
To: qemu-block; +Cc: qemu-devel, Kevin Wolf
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On 08.02.2017 00:57, Max Reitz wrote:
> Currently we only print progress information on retrieval of SIGUSR1.
> Some systems have a dedicated SIGINFO for this, however, so it should be
> handled appropriately if it is available.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1662468
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> Can anyone test this on a BSD system? O:-)
> ---
> util/qemu-progress.c | 3 +++
> qemu-img.texi | 3 ++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
Ping
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] progress: Show current progress on SIGINFO
2017-02-07 23:57 [Qemu-devel] [PATCH] progress: Show current progress on SIGINFO Max Reitz
2017-02-13 14:29 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-18 2:34 ` [Qemu-devel] " Max Reitz
@ 2017-04-13 20:38 ` Max Reitz
2017-04-13 21:11 ` [Qemu-devel] [Qemu-block] " John Snow
2017-04-14 6:27 ` [Qemu-devel] " Fam Zheng
2017-04-28 16:48 ` Max Reitz
3 siblings, 2 replies; 7+ messages in thread
From: Max Reitz @ 2017-04-13 20:38 UTC (permalink / raw)
To: qemu-block; +Cc: qemu-devel, Kevin Wolf
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
On 08.02.2017 00:57, Max Reitz wrote:
> Currently we only print progress information on retrieval of SIGUSR1.
> Some systems have a dedicated SIGINFO for this, however, so it should be
> handled appropriately if it is available.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1662468
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> Can anyone test this on a BSD system? O:-)
> ---
> util/qemu-progress.c | 3 +++
> qemu-img.texi | 3 ++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
Ping
(If nobody replies in the next month or so, I'm just going to merge
this, as util/qemu-progress.c doesn't have a maintainer.)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] progress: Show current progress on SIGINFO
2017-04-13 20:38 ` Max Reitz
@ 2017-04-13 21:11 ` John Snow
2017-04-14 6:27 ` [Qemu-devel] " Fam Zheng
1 sibling, 0 replies; 7+ messages in thread
From: John Snow @ 2017-04-13 21:11 UTC (permalink / raw)
To: Max Reitz, qemu-block; +Cc: Kevin Wolf, qemu-devel
On 04/13/2017 04:38 PM, Max Reitz wrote:
> On 08.02.2017 00:57, Max Reitz wrote:
>> Currently we only print progress information on retrieval of SIGUSR1.
>> Some systems have a dedicated SIGINFO for this, however, so it should be
>> handled appropriately if it is available.
>>
>> Buglink: https://bugs.launchpad.net/qemu/+bug/1662468
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>> Can anyone test this on a BSD system? O:-)
>> ---
>> util/qemu-progress.c | 3 +++
>> qemu-img.texi | 3 ++-
>> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> Ping
>
> (If nobody replies in the next month or so, I'm just going to merge
> this, as util/qemu-progress.c doesn't have a maintainer.)
>
https://www.youtube.com/watch?v=vU54c3YDyak
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] progress: Show current progress on SIGINFO
2017-04-13 20:38 ` Max Reitz
2017-04-13 21:11 ` [Qemu-devel] [Qemu-block] " John Snow
@ 2017-04-14 6:27 ` Fam Zheng
1 sibling, 0 replies; 7+ messages in thread
From: Fam Zheng @ 2017-04-14 6:27 UTC (permalink / raw)
To: Max Reitz; +Cc: qemu-block, Kevin Wolf, qemu-devel
On Thu, 04/13 22:38, Max Reitz wrote:
> On 08.02.2017 00:57, Max Reitz wrote:
> > Currently we only print progress information on retrieval of SIGUSR1.
> > Some systems have a dedicated SIGINFO for this, however, so it should be
> > handled appropriately if it is available.
> >
> > Buglink: https://bugs.launchpad.net/qemu/+bug/1662468
> > Signed-off-by: Max Reitz <mreitz@redhat.com>
> > ---
> > Can anyone test this on a BSD system? O:-)
> > ---
> > util/qemu-progress.c | 3 +++
> > qemu-img.texi | 3 ++-
> > 2 files changed, 5 insertions(+), 1 deletion(-)
>
> Ping
>
> (If nobody replies in the next month or so, I'm just going to merge
> this, as util/qemu-progress.c doesn't have a maintainer.)
qemu-img.c is the sole user, so it implicitly belongs to the block maintainers,
I assume.
Actually, why not add this file under block layer section of MAINTAINERS?
Fam
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] progress: Show current progress on SIGINFO
2017-02-07 23:57 [Qemu-devel] [PATCH] progress: Show current progress on SIGINFO Max Reitz
` (2 preceding siblings ...)
2017-04-13 20:38 ` Max Reitz
@ 2017-04-28 16:48 ` Max Reitz
3 siblings, 0 replies; 7+ messages in thread
From: Max Reitz @ 2017-04-28 16:48 UTC (permalink / raw)
To: qemu-block; +Cc: qemu-devel, Kevin Wolf
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On 08.02.2017 00:57, Max Reitz wrote:
> Currently we only print progress information on retrieval of SIGUSR1.
> Some systems have a dedicated SIGINFO for this, however, so it should be
> handled appropriately if it is available.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1662468
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> Can anyone test this on a BSD system? O:-)
> ---
> util/qemu-progress.c | 3 +++
> qemu-img.texi | 3 ++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
Applied to my block branch.
(https://github.com/XanClic/qemu/commits/block)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-04-28 16:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-07 23:57 [Qemu-devel] [PATCH] progress: Show current progress on SIGINFO Max Reitz
2017-02-13 14:29 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-03-18 2:34 ` [Qemu-devel] " Max Reitz
2017-04-13 20:38 ` Max Reitz
2017-04-13 21:11 ` [Qemu-devel] [Qemu-block] " John Snow
2017-04-14 6:27 ` [Qemu-devel] " Fam Zheng
2017-04-28 16:48 ` Max Reitz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.