From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753152AbdDNORl (ORCPT ); Fri, 14 Apr 2017 10:17:41 -0400 Received: from muru.com ([72.249.23.125]:44420 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752122AbdDNORk (ORCPT ); Fri, 14 Apr 2017 10:17:40 -0400 Date: Fri, 14 Apr 2017 07:17:35 -0700 From: Tony Lindgren To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Wolfram Sang , linux-arm-kernel@lists.infradead.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , devicetree@vger.kernel.org, Rob Herring , Mark Rutland , linux-omap@vger.kernel.org, Russell King , Mark Jackson Subject: Re: [PATCH v3 03/21] ARM: dts: omap: Add generic compatible string for I2C EEPROM Message-ID: <20170414141734.GR5339@atomide.com> References: <20170414010445.21727-1-javier@osg.samsung.com> <20170414010445.21727-4-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170414010445.21727-4-javier@osg.samsung.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Javier Martinez Canillas [170413 18:08]: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas Looks good to me assuming this will get merged in a single series: Acked-by: Tony Lindgren Or if you want me to pick this patch separately, let me know. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v3 03/21] ARM: dts: omap: Add generic compatible string for I2C EEPROM Date: Fri, 14 Apr 2017 07:17:35 -0700 Message-ID: <20170414141734.GR5339@atomide.com> References: <20170414010445.21727-1-javier@osg.samsung.com> <20170414010445.21727-4-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170414010445.21727-4-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Javier Martinez Canillas Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wolfram Sang , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, =?utf-8?Q?Beno=C3=AEt?= Cousson , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Mark Rutland , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , Mark Jackson List-Id: devicetree@vger.kernel.org * Javier Martinez Canillas [170413 18:08]: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas Looks good to me assuming this will get merged in a single series: Acked-by: Tony Lindgren Or if you want me to pick this patch separately, let me know. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 14 Apr 2017 07:17:35 -0700 Subject: [PATCH v3 03/21] ARM: dts: omap: Add generic compatible string for I2C EEPROM In-Reply-To: <20170414010445.21727-4-javier@osg.samsung.com> References: <20170414010445.21727-1-javier@osg.samsung.com> <20170414010445.21727-4-javier@osg.samsung.com> Message-ID: <20170414141734.GR5339@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Javier Martinez Canillas [170413 18:08]: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas Looks good to me assuming this will get merged in a single series: Acked-by: Tony Lindgren Or if you want me to pick this patch separately, let me know. Regards, Tony