From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com ([192.55.52.115]:56094 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751720AbdDNPWe (ORCPT ); Fri, 14 Apr 2017 11:22:34 -0400 Date: Fri, 14 Apr 2017 09:22:33 -0600 From: Ross Zwisler Subject: Re: [PATCH v3 2/4] generic: test mmap io fom DAX to non-DAX Message-ID: <20170414152233.GA5223@linux.intel.com> References: <20170412062608.y2u5og3xz2oly44b@XZHOUW.usersys.redhat.com> <1492008380-29164-1-git-send-email-xzhou@redhat.com> <1492008380-29164-3-git-send-email-xzhou@redhat.com> <20170413041157.rcctxishunypgtvv@XZHOUW.usersys.redhat.com> <20170414100134.iqqou7chjsctpfwh@XZHOUW.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: fstests-owner@vger.kernel.org To: Dan Williams Cc: Xiong Zhou , fstests@vger.kernel.org, Ross Zwisler , jmoyer , Eryu Guan List-ID: On Fri, Apr 14, 2017 at 07:49:48AM -0700, Dan Williams wrote: > On Fri, Apr 14, 2017 at 3:01 AM, Xiong Zhou wrote: > > I agree with Ross that we don't even need ndctl and jq, if we run tests > > on memmap setup. > > I don't understand this comment. How is the test determining if it is > on an memmap defined namespace without querying sysfs? If we we assume that a setup is *either* memmap based or NFIT based, we can choose whether to use jq & ndctl by grepping for "memmap" with a trailing "!" in /proc/cmdline. If you think we need to worry about the case where users have both a valid NFIT and a memmap kernel command line param making them a PMEM region, this shortcut won't work.