All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Sebastian Reichel <sre@kernel.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 08/13] power: max17042_battery: Add support for the TECHNOLOGY attribute
Date: Fri, 14 Apr 2017 18:26:32 +0200	[thread overview]
Message-ID: <20170414162632.7r3id7lkzbcjp3wj@kozik-lap> (raw)
In-Reply-To: <20170414125919.25771-8-hdegoede@redhat.com>

On Fri, Apr 14, 2017 at 02:59:14PM +0200, Hans de Goede wrote:
> The max17042 is intended for LiOn or LiPo batteries, add a TECHNOLOGY
> attribute to reflect this. Note this is hardcoded to LiOn as there is
> no way to tell the difference, this is done by many drivers and is
> better then not providing any technology info at all.

Same as Wolfgang's try:
https://patchwork.kernel.org/patch/9349945/
but with better explanation. :)

Yet still I am not convinced that providing a wrong information (Li-Ion
in case of LiPo battery) is better than not providing any info at all.

Best regards,
Krzysztof

  reply	other threads:[~2017-04-14 16:26 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 12:59 [PATCH 01/13] power: Make power_supply_am_i_supplied return -ENODEV if there are no suppliers Hans de Goede
2017-04-14 12:59 ` [PATCH 02/13] power: max17042_battery: Use sign_extend32 instead of DIY code Hans de Goede
2017-04-14 15:29   ` Krzysztof Kozlowski
2017-04-14 12:59 ` [PATCH 03/13] power: max17047_battery: The temp alert values are 8-bit 2's complement Hans de Goede
2017-04-14 15:09   ` Krzysztof Kozlowski
2017-04-14 15:16     ` Hans de Goede
2017-04-14 15:26       ` Krzysztof Kozlowski
2017-04-14 15:36         ` Hans de Goede
2017-04-14 15:39           ` Krzysztof Kozlowski
2017-04-14 12:59 ` [PATCH 04/13] power: max17042_battery: Add default platform_data for x86 use Hans de Goede
2017-04-14 15:35   ` Krzysztof Kozlowski
2017-04-14 16:07   ` Krzysztof Kozlowski
2017-04-14 17:11     ` Hans de Goede
2017-04-14 12:59 ` [PATCH 05/13] power: max17042_battery: Change name in power_supply_desc to "main-battery" Hans de Goede
2017-04-14 15:37   ` Krzysztof Kozlowski
2017-04-14 12:59 ` [PATCH 06/13] power: max17042_battery: Add support for the STATUS property Hans de Goede
2017-04-14 16:11   ` Krzysztof Kozlowski
2017-04-14 17:19     ` Hans de Goede
2017-04-14 12:59 ` [PATCH 07/13] power: max17042_battery: Add external_power_changed callback Hans de Goede
2017-04-14 16:22   ` Krzysztof Kozlowski
2017-04-14 12:59 ` [PATCH 08/13] power: max17042_battery: Add support for the TECHNOLOGY attribute Hans de Goede
2017-04-14 16:26   ` Krzysztof Kozlowski [this message]
2017-04-14 18:06     ` Hans de Goede
2017-04-14 18:20       ` Krzysztof Kozlowski
2017-04-14 18:24         ` Hans de Goede
2017-04-14 12:59 ` [PATCH 09/13] power: max17042_battery: Add support for the VOLT_MIN property Hans de Goede
2017-04-14 16:29   ` Krzysztof Kozlowski
2017-04-14 12:59 ` [PATCH 10/13] power: max17042_battery: Add support for the CHARGE_FULL_DESIGN property Hans de Goede
2017-04-14 16:34   ` Krzysztof Kozlowski
2017-04-14 18:08     ` Hans de Goede
2017-04-14 12:59 ` [PATCH 11/13] power: max17042_battery: Add support for CHARGE_NOW property Hans de Goede
2017-04-14 16:42   ` Krzysztof Kozlowski
2017-04-14 12:59 ` [PATCH 12/13] power: max17042_battery: Add support for SCOPE property Hans de Goede
2017-04-14 16:43   ` Krzysztof Kozlowski
2017-04-14 12:59 ` [PATCH 13/13] power: max77693_charger: Add supplied_to info to power_supply_config Hans de Goede
2017-04-14 16:44   ` Krzysztof Kozlowski
2017-04-14 13:56 ` [PATCH 01/13] power: Make power_supply_am_i_supplied return -ENODEV if there are no suppliers Krzysztof Kozlowski
2017-04-14 14:07   ` Hans de Goede
2017-04-14 14:31     ` Krzysztof Kozlowski
2017-04-14 15:21       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170414162632.7r3id7lkzbcjp3wj@kozik-lap \
    --to=krzk@kernel.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.