* [U-Boot] [PATCH] arm: omap-common: add missing va_end()
@ 2017-04-15 10:29 Heinrich Schuchardt
2017-04-15 16:11 ` Tom Rini
2017-04-19 13:03 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2017-04-15 10:29 UTC (permalink / raw)
To: u-boot
Each call of va_start must be matched by a call of va_end.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
arch/arm/mach-omap2/sec-common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/sec-common.c b/arch/arm/mach-omap2/sec-common.c
index 0fa8db05fe..ec1ffa556a 100644
--- a/arch/arm/mach-omap2/sec-common.c
+++ b/arch/arm/mach-omap2/sec-common.c
@@ -39,8 +39,10 @@ u32 secure_rom_call(u32 service, u32 proc_id, u32 flag, ...)
num_args = va_arg(ap, u32);
- if (num_args > 4)
+ if (num_args > 4) {
+ va_end(ap);
return 1;
+ }
/* Copy args to aligned args structure */
for (i = 0; i < num_args; i++)
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] arm: omap-common: add missing va_end()
2017-04-15 10:29 [U-Boot] [PATCH] arm: omap-common: add missing va_end() Heinrich Schuchardt
@ 2017-04-15 16:11 ` Tom Rini
2017-04-19 13:03 ` [U-Boot] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-04-15 16:11 UTC (permalink / raw)
To: u-boot
On Sat, Apr 15, 2017 at 12:29:20PM +0200, Heinrich Schuchardt wrote:
> Each call of va_start must be matched by a call of va_end.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170415/2961027f/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] arm: omap-common: add missing va_end()
2017-04-15 10:29 [U-Boot] [PATCH] arm: omap-common: add missing va_end() Heinrich Schuchardt
2017-04-15 16:11 ` Tom Rini
@ 2017-04-19 13:03 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-04-19 13:03 UTC (permalink / raw)
To: u-boot
On Sat, Apr 15, 2017 at 12:29:20PM +0200, xypron.glpk at gmx.de wrote:
> Each call of va_start must be matched by a call of va_end.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170419/2814df80/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-19 13:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-15 10:29 [U-Boot] [PATCH] arm: omap-common: add missing va_end() Heinrich Schuchardt
2017-04-15 16:11 ` Tom Rini
2017-04-19 13:03 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.