All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/2] Add support for rpi3 64bits target
@ 2017-04-14 21:45 Gaël PORTAY
  2017-04-14 21:45 ` [Buildroot] [PATCH 1/2] rpi-firmware: allow to build for aarch64 targets Gaël PORTAY
  2017-04-14 21:45 ` [Buildroot] [PATCH 2/2] configs: add raspberrypi3 64bits defconfig Gaël PORTAY
  0 siblings, 2 replies; 9+ messages in thread
From: Gaël PORTAY @ 2017-04-14 21:45 UTC (permalink / raw)
  To: buildroot

Hi,

Those two patches bring the support for a 64bits image of the RaspberryPi 3.

The first patch makes the rpi-firmware package to be available for aarch64
targets (so it can be used by the second patch).

The second patch adds a minimal defconfig to build a 64bits rpi3 image.

	# uname -a
	Linux buildroot 4.9.13-v8 #1 SMP PREEMPT Fri Apr 14 17:33:30 EDT 2017 aarch64 GNU/Linux

Regards,
Ga?l PORTAY (2):
  rpi-firmware: allow to build for aarch64 targets
  configs: add raspberrypi3 64bits defconfig

 board/raspberrypi/genimage-raspberrypi3-64.cfg | 31 +++++++++++++++++++++
 board/raspberrypi/post-image.sh                | 23 ++++++++++++++++
 configs/raspberrypi3_64_defconfig              | 37 ++++++++++++++++++++++++++
 package/rpi-firmware/Config.in                 |  2 +-
 4 files changed, 92 insertions(+), 1 deletion(-)
 create mode 100644 board/raspberrypi/genimage-raspberrypi3-64.cfg
 create mode 100644 configs/raspberrypi3_64_defconfig

-- 
2.12.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 1/2] rpi-firmware: allow to build for aarch64 targets
  2017-04-14 21:45 [Buildroot] [PATCH 0/2] Add support for rpi3 64bits target Gaël PORTAY
@ 2017-04-14 21:45 ` Gaël PORTAY
  2017-04-15  8:27   ` Thomas Petazzoni
  2017-04-14 21:45 ` [Buildroot] [PATCH 2/2] configs: add raspberrypi3 64bits defconfig Gaël PORTAY
  1 sibling, 1 reply; 9+ messages in thread
From: Gaël PORTAY @ 2017-04-14 21:45 UTC (permalink / raw)
  To: buildroot

The RaspberryPi 3 is based on a AArch64 CPU and requires binaries from
this package.

Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
---
 package/rpi-firmware/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
index c2983aa84..7b37a3072 100644
--- a/package/rpi-firmware/Config.in
+++ b/package/rpi-firmware/Config.in
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_RPI_FIRMWARE
 	bool "rpi-firmware"
-	depends on BR2_arm
+	depends on BR2_arm || BR2_aarch64
 	help
 	  RaspberryPi Firmware
 	  Pre-compiled binaries of the current bootloader and GPU firmware
-- 
2.12.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 2/2] configs: add raspberrypi3 64bits defconfig
  2017-04-14 21:45 [Buildroot] [PATCH 0/2] Add support for rpi3 64bits target Gaël PORTAY
  2017-04-14 21:45 ` [Buildroot] [PATCH 1/2] rpi-firmware: allow to build for aarch64 targets Gaël PORTAY
@ 2017-04-14 21:45 ` Gaël PORTAY
  2017-04-14 22:22   ` Arnout Vandecappelle
  1 sibling, 1 reply; 9+ messages in thread
From: Gaël PORTAY @ 2017-04-14 21:45 UTC (permalink / raw)
  To: buildroot

This configuration builds a 64bit image for RaspberryPi 3.

Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
---
 board/raspberrypi/genimage-raspberrypi3-64.cfg | 31 +++++++++++++++++++++
 board/raspberrypi/post-image.sh                | 23 ++++++++++++++++
 configs/raspberrypi3_64_defconfig              | 37 ++++++++++++++++++++++++++
 3 files changed, 91 insertions(+)
 create mode 100644 board/raspberrypi/genimage-raspberrypi3-64.cfg
 create mode 100644 configs/raspberrypi3_64_defconfig

diff --git a/board/raspberrypi/genimage-raspberrypi3-64.cfg b/board/raspberrypi/genimage-raspberrypi3-64.cfg
new file mode 100644
index 000000000..c5f86527d
--- /dev/null
+++ b/board/raspberrypi/genimage-raspberrypi3-64.cfg
@@ -0,0 +1,31 @@
+image boot.vfat {
+  vfat {
+    files = {
+      "bcm2710-rpi-3-b.dtb",
+      "bcm2837-rpi-3-b.dtb",
+      "rpi-firmware/bootcode.bin",
+      "rpi-firmware/cmdline.txt",
+      "rpi-firmware/config.txt",
+      "rpi-firmware/fixup.dat",
+      "rpi-firmware/start.elf",
+      "Image"
+    }
+  }
+  size = 32M
+}
+
+image sdcard.img {
+  hdimage {
+  }
+
+  partition boot {
+    partition-type = 0xC
+    bootable = "true"
+    image = "boot.vfat"
+  }
+
+  partition rootfs {
+    partition-type = 0x83
+    image = "rootfs.ext4"
+  }
+}
diff --git a/board/raspberrypi/post-image.sh b/board/raspberrypi/post-image.sh
index b2bb07067..e4127c9ea 100755
--- a/board/raspberrypi/post-image.sh
+++ b/board/raspberrypi/post-image.sh
@@ -16,6 +16,29 @@ dtoverlay=pi3-miniuart-bt
 __EOF__
 	fi
 	;;
+	--aarch64)
+	# Run a 64bits kernel (armv8)
+	sed -e '/^kernel=/s,=.*,=Image,' -i "${BINARIES_DIR}/rpi-firmware/config.txt"
+	if ! grep -qE '^arm_control=0x200' "${BINARIES_DIR}/rpi-firmware/config.txt"; then
+		cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
+
+# enable 64bits support
+arm_control=0x200
+__EOF__
+	fi
+
+	# Enable uart console
+	if ! grep -qE '^enable_uart=1' "${BINARIES_DIR}/rpi-firmware/config.txt"; then
+		cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
+
+# enable rpi3 ttyS0 serial console
+enable_uart=1
+__EOF__
+	fi
+
+	# Use 64bits conffile
+	GENIMAGE_CFG="${BOARD_DIR}/genimage-${BOARD_NAME}-64.cfg"
+	;;
 esac
 
 rm -rf "${GENIMAGE_TMP}"
diff --git a/configs/raspberrypi3_64_defconfig b/configs/raspberrypi3_64_defconfig
new file mode 100644
index 000000000..ddc6842f9
--- /dev/null
+++ b/configs/raspberrypi3_64_defconfig
@@ -0,0 +1,37 @@
+BR2_aarch64=y
+
+BR2_GCC_VERSION_6_X=y
+BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+
+BR2_SYSTEM_DHCP="eth0"
+
+# Linux headers same as kernel, a 4.9 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y
+
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_GIT=y
+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="935c7ce84c982a26f567a03a58a1537424569938"
+BR2_LINUX_KERNEL_DEFCONFIG="bcmrpi3"
+
+# Build the DTB from the kernel sources
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="broadcom/bcm2710-rpi-3-b broadcom/bcm2837-rpi-3-b"
+
+BR2_PACKAGE_RPI_FIRMWARE=y
+# BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS is not set
+
+# Required tools to create the SD image
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+
+# Filesystem / image
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_BLOCKS=126976
+# BR2_TARGET_ROOTFS_TAR is not set
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh"
+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="--aarch64"
-- 
2.12.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 2/2] configs: add raspberrypi3 64bits defconfig
  2017-04-14 21:45 ` [Buildroot] [PATCH 2/2] configs: add raspberrypi3 64bits defconfig Gaël PORTAY
@ 2017-04-14 22:22   ` Arnout Vandecappelle
  2017-04-14 23:16     ` Gaël PORTAY
                       ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Arnout Vandecappelle @ 2017-04-14 22:22 UTC (permalink / raw)
  To: buildroot



On 14-04-17 23:45, Ga?l PORTAY wrote:
[snip]
> diff --git a/board/raspberrypi/post-image.sh b/board/raspberrypi/post-image.sh
> index b2bb07067..e4127c9ea 100755
> --- a/board/raspberrypi/post-image.sh
> +++ b/board/raspberrypi/post-image.sh
> @@ -16,6 +16,29 @@ dtoverlay=pi3-miniuart-bt
>  __EOF__
>  	fi
>  	;;
> +	--aarch64)
> +	# Run a 64bits kernel (armv8)
> +	sed -e '/^kernel=/s,=.*,=Image,' -i "${BINARIES_DIR}/rpi-firmware/config.txt"
> +	if ! grep -qE '^arm_control=0x200' "${BINARIES_DIR}/rpi-firmware/config.txt"; then
> +		cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
> +
> +# enable 64bits support
> +arm_control=0x200
> +__EOF__
> +	fi
> +
> +	# Enable uart console
> +	if ! grep -qE '^enable_uart=1' "${BINARIES_DIR}/rpi-firmware/config.txt"; then
> +		cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
> +
> +# enable rpi3 ttyS0 serial console
> +enable_uart=1
> +__EOF__
> +	fi
> +
> +	# Use 64bits conffile
> +	GENIMAGE_CFG="${BOARD_DIR}/genimage-${BOARD_NAME}-64.cfg"

 Isn't it better to just make a new raspberrypi3-64 symlink?

> +	;;
>  esac
>  
>  rm -rf "${GENIMAGE_TMP}"
> diff --git a/configs/raspberrypi3_64_defconfig b/configs/raspberrypi3_64_defconfig
> new file mode 100644
> index 000000000..ddc6842f9
> --- /dev/null
> +++ b/configs/raspberrypi3_64_defconfig
> @@ -0,0 +1,37 @@
> +BR2_aarch64=y

 I think an explicit BR2_cortex_a53=y should be added. It's the default because
it's the first one in the list, but I don't think it's good to rely on that.

 BTW, does anyone know why the 32-bit version has cortex_a7?

> +
> +BR2_GCC_VERSION_6_X=y
> +BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
> +BR2_TOOLCHAIN_BUILDROOT_CXX=y
> +
> +BR2_SYSTEM_DHCP="eth0"
> +
> +# Linux headers same as kernel, a 4.9 series
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y
> +
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="935c7ce84c982a26f567a03a58a1537424569938"
> +BR2_LINUX_KERNEL_DEFCONFIG="bcmrpi3"
> +
> +# Build the DTB from the kernel sources
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="broadcom/bcm2710-rpi-3-b broadcom/bcm2837-rpi-3-b"
> +
> +BR2_PACKAGE_RPI_FIRMWARE=y
> +# BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS is not set
> +
> +# Required tools to create the SD image
> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_PACKAGE_HOST_MTOOLS=y
> +
> +# Filesystem / image
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_BLOCKS=126976

 I'd prefer a little bit more slack, I used 120000 in the defconfigs I just
updated. And if that is not enough (or very tight), just jump directly to 250000.

 Regards,
 Arnout

> +# BR2_TARGET_ROOTFS_TAR is not set
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh"
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="--aarch64"
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 2/2] configs: add raspberrypi3 64bits defconfig
  2017-04-14 22:22   ` Arnout Vandecappelle
@ 2017-04-14 23:16     ` Gaël PORTAY
  2017-04-14 23:23     ` Gaël PORTAY
  2017-04-15  8:26     ` Thomas Petazzoni
  2 siblings, 0 replies; 9+ messages in thread
From: Gaël PORTAY @ 2017-04-14 23:16 UTC (permalink / raw)
  To: buildroot

Hi Arnout,

On Sat, Apr 15, 2017 at 12:22:12AM +0200, Arnout Vandecappelle wrote:
> 
> 
> On 14-04-17 23:45, Ga?l PORTAY wrote:
> [snip]
> > diff --git a/board/raspberrypi/post-image.sh b/board/raspberrypi/post-image.sh
> > index b2bb07067..e4127c9ea 100755
> > --- a/board/raspberrypi/post-image.sh
> > +++ b/board/raspberrypi/post-image.sh
> > @@ -16,6 +16,29 @@ dtoverlay=pi3-miniuart-bt
> >  __EOF__
> >  	fi
> >  	;;
> > +	--aarch64)
> > +	# Run a 64bits kernel (armv8)
> > +	sed -e '/^kernel=/s,=.*,=Image,' -i "${BINARIES_DIR}/rpi-firmware/config.txt"
> > +	if ! grep -qE '^arm_control=0x200' "${BINARIES_DIR}/rpi-firmware/config.txt"; then
> > +		cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
> > +
> > +# enable 64bits support
> > +arm_control=0x200
> > +__EOF__
> > +	fi
> > +
> > +	# Enable uart console
> > +	if ! grep -qE '^enable_uart=1' "${BINARIES_DIR}/rpi-firmware/config.txt"; then
> > +		cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
> > +
> > +# enable rpi3 ttyS0 serial console
> > +enable_uart=1
> > +__EOF__
> > +	fi
> > +
> > +	# Use 64bits conffile
> > +	GENIMAGE_CFG="${BOARD_DIR}/genimage-${BOARD_NAME}-64.cfg"
> 
>  Isn't it better to just make a new raspberrypi3-64 symlink?
> 

I am sorry, could you detail a bit more... I did not get it :/

> > +	;;
> >  esac
> >  
> >  rm -rf "${GENIMAGE_TMP}"
> > diff --git a/configs/raspberrypi3_64_defconfig b/configs/raspberrypi3_64_defconfig
> > new file mode 100644
> > index 000000000..ddc6842f9
> > --- /dev/null
> > +++ b/configs/raspberrypi3_64_defconfig
> > @@ -0,0 +1,37 @@
> > +BR2_aarch64=y
> 
>  I think an explicit BR2_cortex_a53=y should be added. It's the default because
> it's the first one in the list, but I don't think it's good to rely on that.
> 

Indeed, it was present in my first draft. I did savedefconfig and cleaned it
up, and make it disappeared :(

>  BTW, does anyone know why the 32-bit version has cortex_a7?
> 

I think I was the magic a copy/paste. I have a patch to update the 32bit version
to cortex_a53, but it breaks compilation of qt5base.

I am still working on it. I located the bug but I don't know yet how to fix it
(properly).

To sum-up, setting BR2_cortex_a53 builds an armv8 toolchain that outputs 32bits
binaries.

Here are the ARM defines.

	#define __arm__ 1
	#define __ARM_32BIT_STATE 1
	#define __ARM_ARCH 8
	#define __ARM_ARCH_8A__ 1
	#define __ARM_ARCH_EXT_IDIV__ 1
	#define __ARM_ARCH_ISA_ARM 1
	#define __ARM_ARCH_ISA_THUMB 2
	#define __ARM_ARCH_PROFILE 65
	#define __ARM_EABI__ 1
	#define __ARMEL__ 1
	#define __ARM_FEATURE_CLZ 1
	#define __ARM_FEATURE_CRC32 1
	#define __ARM_FEATURE_DSP 1
	#define __ARM_FEATURE_IDIV 1
	#define __ARM_FEATURE_LDREX 15
	#define __ARM_FEATURE_QBIT 1
	#define __ARM_FEATURE_SAT 1
	#define __ARM_FEATURE_SIMD32 1
	#define __ARM_FEATURE_UNALIGNED 1
	#define __ARM_PCS 1
	#define __ARM_SIZEOF_MINIMAL_ENUM 4
	#define __ARM_SIZEOF_WCHAR_T 4

The flag __ARM_FEATURE_CRC32 is now defined and qtbase uses the AArch32/AArch64
CRC instructions to build an hardware accelerated implementation of its crc32
function [1].

	tools/qhash.cpp:148:54: error: attribute(target("+crc")) is unknown
	 static uint crc32(const Char *ptr, size_t len, uint h)

+crc is an ARMv8 only attribute [2]. __ARM_FEATURE_CRC32 is set for both AArch32
and AArch64 [3].

	6.5.8 CRC32 Extension
	__ARM_FEATURE_CRC32 is defined to 1 if the CRC32 instructions are
	supported and the intrinsics defined in 9.7 are available. These
	instructions include CRC32B, CRC32H etc. This is only available when
	__ARM_ARCH >= 8

	9.7 CRC32 intrinsics
	CRC32 intrinsics provide direct access to CRC32 instructions
	CRC32{C}{B, H, W, X} in both ARMv8 AArch32 and AArch64 execution states.
	These intrinsics are available when __ARM_FEATURE_CRC32 is defined.

The quick fix I found is to check for both define __aarch64__ and
__ARM_FEATURE_CRC32 instead of checking the single define __ARM_FEATURE_CRC32.

	#if defined(__aarch64__) && defined(__ARM_FEATURE_CRC32)

If anyone knows on which flag I can rely on... I can open a dedicated thread
about this bug.

> > +
> > +BR2_GCC_VERSION_6_X=y
> > +BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
> > +BR2_TOOLCHAIN_BUILDROOT_CXX=y
> > +
> > +BR2_SYSTEM_DHCP="eth0"
> > +
> > +# Linux headers same as kernel, a 4.9 series
> > +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_9=y
> > +
> > +BR2_LINUX_KERNEL=y
> > +BR2_LINUX_KERNEL_CUSTOM_GIT=y
> > +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/raspberrypi/linux.git"
> > +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="935c7ce84c982a26f567a03a58a1537424569938"
> > +BR2_LINUX_KERNEL_DEFCONFIG="bcmrpi3"
> > +
> > +# Build the DTB from the kernel sources
> > +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="broadcom/bcm2710-rpi-3-b broadcom/bcm2837-rpi-3-b"
> > +
> > +BR2_PACKAGE_RPI_FIRMWARE=y
> > +# BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS is not set
> > +
> > +# Required tools to create the SD image
> > +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> > +BR2_PACKAGE_HOST_GENIMAGE=y
> > +BR2_PACKAGE_HOST_MTOOLS=y
> > +
> > +# Filesystem / image
> > +BR2_TARGET_ROOTFS_EXT2=y
> > +BR2_TARGET_ROOTFS_EXT2_4=y
> > +BR2_TARGET_ROOTFS_EXT2_BLOCKS=126976
> 
>  I'd prefer a little bit more slack, I used 120000 in the defconfigs I just
> updated. And if that is not enough (or very tight), just jump directly to 250000.
> 

Okay.

>  Regards,
>  Arnout
> 
> > +# BR2_TARGET_ROOTFS_TAR is not set
> > +BR2_ROOTFS_POST_BUILD_SCRIPT="board/raspberrypi3/post-build.sh"
> > +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/raspberrypi3/post-image.sh"
> > +BR2_ROOTFS_POST_SCRIPT_ARGS="--aarch64"
> > 
> 
> -- 
> Arnout Vandecappelle                          arnout at mind be
> Senior Embedded Software Architect            +32-16-286500
> Essensium/Mind                                http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

Regards,
Ga?l

[1] https://github.com/qt/qtbase/blob/5.8/src/corelib/tools/qhash.cpp#L140
[2] https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html#g_t-march-and--mcpu-Feature-Modifiers
[3] http://infocenter.arm.com/help/topic/com.arm.doc.ihi0053c/IHI0053C_acle_2_0.pdf

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 2/2] configs: add raspberrypi3 64bits defconfig
  2017-04-14 22:22   ` Arnout Vandecappelle
  2017-04-14 23:16     ` Gaël PORTAY
@ 2017-04-14 23:23     ` Gaël PORTAY
  2017-04-15  8:26     ` Thomas Petazzoni
  2 siblings, 0 replies; 9+ messages in thread
From: Gaël PORTAY @ 2017-04-14 23:23 UTC (permalink / raw)
  To: buildroot

Arnout,

On Sat, Apr 15, 2017 at 12:22:12AM +0200, Arnout Vandecappelle wrote:
> 
> On 14-04-17 23:45, Ga?l PORTAY wrote:
> [snip]
> > diff --git a/board/raspberrypi/post-image.sh b/board/raspberrypi/post-image.sh
> > index b2bb07067..e4127c9ea 100755
> > --- a/board/raspberrypi/post-image.sh
> > +++ b/board/raspberrypi/post-image.sh
> > @@ -16,6 +16,29 @@ dtoverlay=pi3-miniuart-bt
> >  __EOF__
> >  	fi
> >  	;;
> > +	--aarch64)
> > +	# Run a 64bits kernel (armv8)
> > +	sed -e '/^kernel=/s,=.*,=Image,' -i "${BINARIES_DIR}/rpi-firmware/config.txt"
> > +	if ! grep -qE '^arm_control=0x200' "${BINARIES_DIR}/rpi-firmware/config.txt"; then
> > +		cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
> > +
> > +# enable 64bits support
> > +arm_control=0x200
> > +__EOF__
> > +	fi
> > +
> > +	# Enable uart console
> > +	if ! grep -qE '^enable_uart=1' "${BINARIES_DIR}/rpi-firmware/config.txt"; then
> > +		cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
> > +
> > +# enable rpi3 ttyS0 serial console
> > +enable_uart=1
> > +__EOF__
> > +	fi
> > +
> > +	# Use 64bits conffile
> > +	GENIMAGE_CFG="${BOARD_DIR}/genimage-${BOARD_NAME}-64.cfg"
> 
>  Isn't it better to just make a new raspberrypi3-64 symlink?
> 

Indeed, the symlink make sense.

> > +	;;
> >  esac
> >  
> >  rm -rf "${GENIMAGE_TMP}"

Regards,
Ga?l

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 2/2] configs: add raspberrypi3 64bits defconfig
  2017-04-14 22:22   ` Arnout Vandecappelle
  2017-04-14 23:16     ` Gaël PORTAY
  2017-04-14 23:23     ` Gaël PORTAY
@ 2017-04-15  8:26     ` Thomas Petazzoni
  2 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2017-04-15  8:26 UTC (permalink / raw)
  To: buildroot

Hello,

On Sat, 15 Apr 2017 00:22:12 +0200, Arnout Vandecappelle wrote:

>  BTW, does anyone know why the 32-bit version has cortex_a7?

I think because back when the rpi3 defconfig was added, there was no
selection of AArch64 cores.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 1/2] rpi-firmware: allow to build for aarch64 targets
  2017-04-14 21:45 ` [Buildroot] [PATCH 1/2] rpi-firmware: allow to build for aarch64 targets Gaël PORTAY
@ 2017-04-15  8:27   ` Thomas Petazzoni
  2017-04-15 11:43     ` Gaël PORTAY
  0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2017-04-15  8:27 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri, 14 Apr 2017 17:45:50 -0400, Ga?l PORTAY wrote:
> The RaspberryPi 3 is based on a AArch64 CPU and requires binaries from
> this package.
> 
> Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
> ---
>  package/rpi-firmware/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Buildroot] [PATCH 1/2] rpi-firmware: allow to build for aarch64 targets
  2017-04-15  8:27   ` Thomas Petazzoni
@ 2017-04-15 11:43     ` Gaël PORTAY
  0 siblings, 0 replies; 9+ messages in thread
From: Gaël PORTAY @ 2017-04-15 11:43 UTC (permalink / raw)
  To: buildroot

Thomas,

On Sat, Apr 15, 2017 at 10:27:27AM +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Fri, 14 Apr 2017 17:45:50 -0400, Ga?l PORTAY wrote:
> > The RaspberryPi 3 is based on a AArch64 CPU and requires binaries from
> > this package.
> > 
> > Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
> > ---
> >  package/rpi-firmware/Config.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied to master, thanks.
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

Thanks.

Ga?l

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-04-15 11:43 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-14 21:45 [Buildroot] [PATCH 0/2] Add support for rpi3 64bits target Gaël PORTAY
2017-04-14 21:45 ` [Buildroot] [PATCH 1/2] rpi-firmware: allow to build for aarch64 targets Gaël PORTAY
2017-04-15  8:27   ` Thomas Petazzoni
2017-04-15 11:43     ` Gaël PORTAY
2017-04-14 21:45 ` [Buildroot] [PATCH 2/2] configs: add raspberrypi3 64bits defconfig Gaël PORTAY
2017-04-14 22:22   ` Arnout Vandecappelle
2017-04-14 23:16     ` Gaël PORTAY
2017-04-14 23:23     ` Gaël PORTAY
2017-04-15  8:26     ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.