All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@fb.com>, linux-block@vger.kernel.org
Cc: Christoph Hellwig <hch@infradead.org>,
	Omar Sandoval <osandov@fb.com>,
	Jozef Mikovic <jmikovic@redhat.com>,
	Ming Lei <ming.lei@redhat.com>
Subject: [PATCH 4/4] mtip32xx: use BLK_MQ_F_USE_SCHED_TAG
Date: Sat, 15 Apr 2017 20:38:25 +0800	[thread overview]
Message-ID: <20170415123825.32716-5-ming.lei@redhat.com> (raw)
In-Reply-To: <20170415123825.32716-1-ming.lei@redhat.com>

This patch applys the new introduced flag of BLK_MQ_F_USE_SCHED_TAG
to make mq-deadline working on mtip32xx. With this flag, we can
allocate hardware tag for scheduler, then mtip32xx can work well.

Also mtip32xx has 256 queue depth, which is same with the default
value of q->nr_requests, so in theory performance loss won't happen.

Finally BLK_MQ_F_NO_SCHED isn't necessary any more.

Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 drivers/block/mtip32xx/mtip32xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 4e344246c8dd..203b18a9eff0 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -3969,7 +3969,7 @@ static int mtip_block_initialize(struct driver_data *dd)
 	dd->tags.reserved_tags = 1;
 	dd->tags.cmd_size = sizeof(struct mtip_cmd);
 	dd->tags.numa_node = dd->numa_node;
-	dd->tags.flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_NO_SCHED;
+	dd->tags.flags = BLK_MQ_F_SHOULD_MERGE | BLK_MQ_F_SCHED_USE_HW_TAG;
 	dd->tags.driver_data = dd;
 	dd->tags.timeout = MTIP_NCQ_CMD_TIMEOUT_MS;
 
-- 
2.9.3

  parent reply	other threads:[~2017-04-15 12:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-15 12:38 [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched Ming Lei
2017-04-15 12:38 ` [PATCH 1/4] block: respect BLK_MQ_F_NO_SCHED Ming Lei
2017-04-15 12:38 ` [PATCH 2/4] mtip32xx: pass BLK_MQ_F_NO_SCHED Ming Lei
2017-04-15 12:38 ` [PATCH 3/4] blk-mq: introduce BLK_MQ_F_SCHED_USE_HW_TAG Ming Lei
2017-04-15 12:38 ` Ming Lei [this message]
2017-04-16 16:03 ` [PATCH 0/4] blk-mq-sched: allow to use hw tag for sched Ming Lei
2017-04-17 17:30   ` Omar Sandoval
2017-04-19  1:10     ` Ming Lei
2017-04-19 20:17 ` Jens Axboe
2017-04-20  0:44   ` Ming Lei
2017-04-20  0:55     ` Jens Axboe
2017-04-20  1:03       ` Ming Lei
2017-04-20  4:54         ` Christoph Hellwig
2017-04-20  8:30           ` Ming Lei
2017-04-26 10:48             ` Ming Lei
2017-04-26 18:15               ` Jens Axboe
2017-04-26 18:22                 ` Jens Axboe
2017-04-27  3:14                   ` Ming Lei
2017-04-27 13:49                     ` Jens Axboe
2017-04-27 15:20                       ` Christoph Hellwig
2017-04-27 15:46                         ` Jens Axboe
2017-04-27 21:40                           ` Jens Axboe
2017-04-27  6:32               ` Christoph Hellwig
2017-04-20 16:10           ` Jens Axboe
2017-04-21 10:54             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170415123825.32716-5-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    --cc=axboe@fb.com \
    --cc=hch@infradead.org \
    --cc=jmikovic@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.