From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755073AbdDQRgW convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Mon, 17 Apr 2017 13:36:22 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:55904 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754929AbdDQRgV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 17 Apr 2017 13:36:21 -0400
Date: Mon, 17 Apr 2017 13:36:19 -0400 (EDT)
Message-Id: <20170417.133619.1515025171498720534.davem@davemloft.net>
To: clg@kaod.org
Cc: gwshan@linux.vnet.ibm.com, joel@jms.id.au, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/ncsi: fix checksum validation in response packet
From: David Miller <davem@davemloft.net>
In-Reply-To: <1492160197-13816-1-git-send-email-clg@kaod.org>
References: <1492160197-13816-1-git-send-email-clg@kaod.org>
X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Apr 2017 09:54:59 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Cédric Le Goater <clg@kaod.org>
Date: Fri, 14 Apr 2017 10:56:37 +0200

> htonl was used instead of ntohl. Surely a typo.
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>

I don't think so, "checksum" is of type "u32" thus is in host byte
order.  Therefore "htonl()" is correct.