All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@nongnu.org, jsnow@redhat.com,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Fam Zheng <famz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
	Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 08/31] block: Switch BdrvCoGetBlockStatusData to byte-based
Date: Mon, 17 Apr 2017 20:33:33 -0500	[thread overview]
Message-ID: <20170418013356.3578-9-eblake@redhat.com> (raw)
In-Reply-To: <20170418013356.3578-1-eblake@redhat.com>

We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based.  Convert another internal
type (no semantic change), and rename it to match the corresponding
public function rename.

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 block/io.c | 30 +++++++++++++++++-------------
 1 file changed, 17 insertions(+), 13 deletions(-)

diff --git a/block/io.c b/block/io.c
index e804bdd..f7ece8d 100644
--- a/block/io.c
+++ b/block/io.c
@@ -1680,16 +1680,16 @@ int bdrv_flush_all(void)
 }


-typedef struct BdrvCoGetBlockStatusData {
+typedef struct BdrvCoBlockStatusData {
     BlockDriverState *bs;
     BlockDriverState *base;
     BlockDriverState **file;
-    int64_t sector_num;
-    int nb_sectors;
-    int *pnum;
+    int64_t offset;
+    int64_t bytes;
+    int64_t *pnum;
     int64_t ret;
     bool done;
-} BdrvCoGetBlockStatusData;
+} BdrvCoBlockStatusData;

 /*
  * Returns the allocation status of the specified sectors.
@@ -1850,13 +1850,15 @@ static int64_t coroutine_fn bdrv_co_get_block_status_above(BlockDriverState *bs,
 /* Coroutine wrapper for bdrv_get_block_status_above() */
 static void coroutine_fn bdrv_get_block_status_above_co_entry(void *opaque)
 {
-    BdrvCoGetBlockStatusData *data = opaque;
+    BdrvCoBlockStatusData *data = opaque;
+    int n;

     data->ret = bdrv_co_get_block_status_above(data->bs, data->base,
-                                               data->sector_num,
-                                               data->nb_sectors,
-                                               data->pnum,
+                                               data->offset >> BDRV_SECTOR_BITS,
+                                               data->bytes >> BDRV_SECTOR_BITS,
+                                               &n,
                                                data->file);
+    *data->pnum = n * BDRV_SECTOR_SIZE;
     data->done = true;
 }

@@ -1872,13 +1874,14 @@ int64_t bdrv_get_block_status_above(BlockDriverState *bs,
                                     BlockDriverState **file)
 {
     Coroutine *co;
-    BdrvCoGetBlockStatusData data = {
+    int64_t n;
+    BdrvCoBlockStatusData data = {
         .bs = bs,
         .base = base,
         .file = file,
-        .sector_num = sector_num,
-        .nb_sectors = nb_sectors,
-        .pnum = pnum,
+        .offset = sector_num * BDRV_SECTOR_SIZE,
+        .bytes = nb_sectors * BDRV_SECTOR_SIZE,
+        .pnum = &n,
         .done = false,
     };

@@ -1891,6 +1894,7 @@ int64_t bdrv_get_block_status_above(BlockDriverState *bs,
         bdrv_coroutine_enter(bs, co);
         BDRV_POLL_WHILE(bs, !data.done);
     }
+    *pnum = n >> BDRV_SECTOR_BITS;
     return data.ret;
 }

-- 
2.9.3

  parent reply	other threads:[~2017-04-18  1:34 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18  1:33 [Qemu-devel] [PATCH 00/31] make bdrv_get_block_status byte-based Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 01/31] block: Drop unused bdrv_round_sectors_to_clusters() Eric Blake
2017-04-26 21:41   ` John Snow
2017-04-18  1:33 ` [Qemu-devel] [PATCH 02/31] block: Make bdrv_round_to_clusters() signature more useful Eric Blake
2017-04-26 21:41   ` John Snow
2017-04-26 21:47     ` Eric Blake
2017-04-26 21:54       ` John Snow
2017-04-18  1:33 ` [Qemu-devel] [PATCH 03/31] qcow2: Switch is_zero_sectors() to byte-based Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 04/31] block: Switch bdrv_make_zero() " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 05/31] qemu-img: Switch get_block_status() " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 06/31] block: Convert bdrv_get_block_status() to bytes Eric Blake
2017-04-18 21:34   ` [Qemu-devel] [PATCH v1.5 06.5/31] fixup! " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 07/31] block: Switch bdrv_co_get_block_status() to byte-based Eric Blake
2017-04-18  1:33 ` Eric Blake [this message]
2017-04-18  1:33 ` [Qemu-devel] [PATCH 09/31] block: Switch bdrv_co_get_block_status_above() " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 10/31] block: Convert bdrv_get_block_status_above() to bytes Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 11/31] block: Add .bdrv_co_block_status() callback Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 12/31] commit: Switch to .bdrv_co_block_status() Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 13/31] file-posix: " Eric Blake
2017-04-18 20:56   ` Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 14/31] gluster: " Eric Blake
2017-04-19 13:26   ` [Qemu-devel] [Qemu-block] " Niels de Vos
2017-04-19 14:06   ` [Qemu-devel] " Prasanna Kalever
2017-04-19 14:08     ` Prasanna Kalever
2017-04-18  1:33 ` [Qemu-devel] [PATCH 15/31] iscsi: Switch cluster_sectors to byte-based Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 16/31] iscsi: Switch iscsi_allocmap_update() " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 17/31] iscsi: Switch to .bdrv_co_block_status() Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 18/31] mirror: " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 19/31] null: " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 20/31] parallels: " Eric Blake
2017-04-18 10:28   ` Denis V. Lunev
2017-04-18  1:33 ` [Qemu-devel] [PATCH 21/31] qcow: " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 22/31] qcow2: " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 23/31] qed: " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 24/31] raw: " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 25/31] sheepdog: " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 26/31] vdi: Avoid bitrot of debugging code Eric Blake
2017-04-18  5:13   ` Stefan Weil
2017-05-13 20:35     ` Philippe Mathieu-Daudé
2017-04-18  1:33 ` [Qemu-devel] [PATCH 27/31] vdi: Switch to .bdrv_co_block_status() Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 28/31] vmdk: " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 29/31] vpc: " Eric Blake
2017-07-13 12:55   ` Kevin Wolf
2017-07-13 13:52     ` Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 30/31] vvfat: " Eric Blake
2017-04-18  1:33 ` [Qemu-devel] [PATCH 31/31] block: Drop unused .bdrv_co_get_block_status() Eric Blake
2017-04-18  1:37 ` [Qemu-devel] [Qemu-block] [PATCH 00/31] make bdrv_get_block_status byte-based Eric Blake
2017-04-18 20:23 ` [Qemu-devel] " Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170418013356.3578-9-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@nongnu.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.