From: Michal Hocko <mhocko@kernel.org>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "hughd@google.com" <hughd@google.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"oleg@redhat.com" <oleg@redhat.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"hare@suse.com" <hare@suse.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
"jack@suse.cz" <jack@suse.cz>
Subject: Re: [PATCH] mm: Make truncate_inode_pages_range() killable
Date: Tue, 18 Apr 2017 10:15:49 +0200 [thread overview]
Message-ID: <20170418081549.GJ22360@dhcp22.suse.cz> (raw)
In-Reply-To: <1492217984.2557.1.camel@sandisk.com>
On Sat 15-04-17 00:59:46, Bart Van Assche wrote:
> On Fri, 2017-04-14 at 17:40 -0700, Hugh Dickins wrote:
> > Changing a fundamental function, silently not to do its essential job,
> > when something in the kernel has forgotten (or is slow to) unlock_page():
> > that seems very wrong to me in many ways. But linux-fsdevel, Cc'ed, will
> > be a better forum to advise on how to solve the problem you're seeing.
>
> Hello Hugh,
>
> It seems like you have misunderstood the purpose of the patch I posted. It's
> neither a missing unlock_page() nor slow I/O that I want to address but a
> genuine deadlock. In case you would not be familiar with the queue_if_no_path
> multipath configuration option, the multipath.conf man page is available at
> e.g. https://linux.die.net/man/5/multipath.conf.
So, whole is holding the page lock and why it cannot make forward
progress? Is the storage gone so that the ongoing IO will never
terminate? Btw. we have many other places which wait for the page lock
!killable way. Why they are any different from this case?
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-04-18 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 21:55 [PATCH] mm: Make truncate_inode_pages_range() killable Bart Van Assche
2017-04-14 23:45 ` Bart Van Assche
2017-04-15 0:40 ` Hugh Dickins
2017-04-15 0:59 ` Bart Van Assche
2017-04-18 8:15 ` Michal Hocko [this message]
2017-04-18 22:09 ` Bart Van Assche
2017-04-18 14:42 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418081549.GJ22360@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=Bart.VanAssche@sandisk.com \
--cc=akpm@linux-foundation.org \
--cc=hare@suse.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=oleg@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.