From: Karel Zak <kzak@redhat.com>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: util-linux@vger.kernel.org,
Benno Schulenberg <bensberg@justemail.net>,
Bart Van Assche <Bart.VanAssche@sandisk.com>
Subject: Re: [PATCH] blkzone: Fix zone condition strings handling
Date: Tue, 18 Apr 2017 11:34:40 +0200 [thread overview]
Message-ID: <20170418093440.4d6haj4iqfguonwd@ws.net.home> (raw)
In-Reply-To: <20170412092032.7234-1-damien.lemoal@wdc.com>
On Wed, Apr 12, 2017 at 06:20:32PM +0900, Damien Le Moal wrote:
> Fixed the condition strings for implicit open and explicit open to
> match the man page defined strings ("oi" and "oe"). Also while at it,
> correct the condition_str array entries adding the reserved "xC" case
> so that the read_only, full and offline conditions match the condition
> codes. This increases the array size to 16, so also fix the condition
> code masking when displaying the result.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> sys-utils/blkzone.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Applied, thanks.
Damien, what about to add ZONED column to the lsblk(8) command (also
from util-linux)?
It would be nice to have zone model there. All lsblk is based on /sys,
so add the string from /sys/block/<disk>/queue/zoned should be easy
(just add COL_ZONED with sysfs_strdup() to set_scols_data()).
lsblk -o+ZONED
will do all the magic for end users. Can you try it? I have no way to
test it.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2017-04-18 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 9:20 [PATCH] blkzone: Fix zone condition strings handling Damien Le Moal
2017-04-18 9:34 ` Karel Zak [this message]
2017-04-18 10:59 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418093440.4d6haj4iqfguonwd@ws.net.home \
--to=kzak@redhat.com \
--cc=Bart.VanAssche@sandisk.com \
--cc=bensberg@justemail.net \
--cc=damien.lemoal@wdc.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.