All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: tamas@tklengyel.com, wei.liu2@citrix.com,
	rcojocaru@bitdefender.com, george.dunlap@eu.citrix.com,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
	alistair23@gmail.com
Subject: Re: [PATCH 1/2] tools: Use POSIX poll.h instead of sys/poll.h
Date: Tue, 18 Apr 2017 11:10:59 +0100	[thread overview]
Message-ID: <20170418101059.5ytj42tjfamyladk@citrix.com> (raw)
In-Reply-To: <20170417213311.29924-1-alistair.francis@xilinx.com>

Cc Julien

I think these two patches should be in 4.9.

On Mon, Apr 17, 2017 at 02:33:10PM -0700, Alistair Francis wrote:
> The POSIX spec specifies to use:
>     #include <poll.h>
> instead of:
>     #include <sys/poll.h>
> as seen here:
>     http://pubs.opengroup.org/onlinepubs/009695399/functions/poll.html
> 
> This removes the warning:
>     #warning redirecting incorrect #include <sys/poll.h> to <poll.h>
> when building with the musl C-library.
> 
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
>  tools/libxl/libxl_internal.h               | 2 +-
>  tools/tests/xen-access/xen-access.c        | 2 +-
>  tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +-
>  tools/xentrace/xentrace.c                  | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index be24b76dfa..5d082c5704 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -38,7 +38,7 @@
>  #include <ctype.h>
>  
>  #include <sys/mman.h>
> -#include <sys/poll.h>
> +#include <poll.h>
>  #include <sys/select.h>
>  #include <sys/stat.h>
>  #include <sys/time.h>
> diff --git a/tools/tests/xen-access/xen-access.c b/tools/tests/xen-access/xen-access.c
> index ff4d289b45..238011e010 100644
> --- a/tools/tests/xen-access/xen-access.c
> +++ b/tools/tests/xen-access/xen-access.c
> @@ -36,7 +36,7 @@
>  #include <signal.h>
>  #include <unistd.h>
>  #include <sys/mman.h>
> -#include <sys/poll.h>
> +#include <poll.h>
>  
>  #include <xenctrl.h>
>  #include <xenevtchn.h>
> diff --git a/tools/xenstat/libxenstat/src/xenstat_qmp.c b/tools/xenstat/libxenstat/src/xenstat_qmp.c
> index a87c9373c2..3fda487d49 100644
> --- a/tools/xenstat/libxenstat/src/xenstat_qmp.c
> +++ b/tools/xenstat/libxenstat/src/xenstat_qmp.c
> @@ -14,7 +14,7 @@
>  #include <fcntl.h>
>  #include <sys/types.h>
>  #include <sys/socket.h>
> -#include <sys/poll.h>
> +#include <poll.h>
>  #include <sys/un.h>
>  #include <stdlib.h>
>  #include <string.h>
> diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
> index f09fe6cf19..364a6fdad5 100644
> --- a/tools/xentrace/xentrace.c
> +++ b/tools/xentrace/xentrace.c
> @@ -24,7 +24,7 @@
>  #include <getopt.h>
>  #include <assert.h>
>  #include <ctype.h>
> -#include <sys/poll.h>
> +#include <poll.h>
>  #include <sys/statvfs.h>
>  
>  #include <xen/xen.h>
> -- 
> 2.11.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-04-18 10:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 21:33 [PATCH 1/2] tools: Use POSIX poll.h instead of sys/poll.h Alistair Francis
2017-04-17 21:33 ` [PATCH 2/2] tools: Use POSIX signal.h instead of sys/signal.h Alistair Francis
2017-04-18 10:03   ` Wei Liu
2017-04-18 10:16     ` Razvan Cojocaru
2017-04-18 11:42       ` Wei Liu
2017-04-18 13:22   ` [for-4.9] " Ian Jackson
2017-04-18 10:02 ` [PATCH 1/2] tools: Use POSIX poll.h instead of sys/poll.h Wei Liu
2017-04-18 10:14   ` Razvan Cojocaru
2017-04-18 10:10 ` Wei Liu [this message]
2017-04-18 10:13   ` Wei Liu
2017-04-18 11:30     ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170418101059.5ytj42tjfamyladk@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=alistair.francis@xilinx.com \
    --cc=alistair23@gmail.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=rcojocaru@bitdefender.com \
    --cc=tamas@tklengyel.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.