From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756234AbdDRMc1 (ORCPT ); Tue, 18 Apr 2017 08:32:27 -0400 Received: from merlin.infradead.org ([205.233.59.134]:41156 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752425AbdDRMcX (ORCPT ); Tue, 18 Apr 2017 08:32:23 -0400 Date: Tue, 18 Apr 2017 14:32:16 +0200 From: Peter Zijlstra To: Lauro Venancio Cc: linux-kernel@vger.kernel.org, lwang@redhat.com, riel@redhat.com, Mike Galbraith , Thomas Gleixner , Ingo Molnar Subject: Re: [RFC 3/3] sched/topology: Different sched groups must not have the same balance cpu Message-ID: <20170418123216.r67dymncczjj6zw7@hirez.programming.kicks-ass.net> References: <1492091769-19879-1-git-send-email-lvenanci@redhat.com> <1492091769-19879-4-git-send-email-lvenanci@redhat.com> <20170414164909.tfybszncwkm4yxap@hirez.programming.kicks-ass.net> <731e0515-63e8-2a58-832d-89619065a328@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <731e0515-63e8-2a58-832d-89619065a328@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 17, 2017 at 12:34:05PM -0300, Lauro Venancio wrote: > This patch ensures tree things: > > 1) different instances of the same group share the same > sched_group_capacity instance. > > 2) instances of different groups don't share the same > sched_group_capacity instance. > > 3) the group balance cpu must be one of the cpus where the group is > installed. > > > I am rebasing this patch on top of your patches. Well, I would rather have 3 patches, each with a comprehensible changelog. I had already rebased the patch (trivial) so that's not the problem. Explaining what and why it does things is. And as per the usual rules, if it does 3 things it should be 3 patches.