From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 18 Apr 2017 09:28:22 -0700 From: "Luck, Tony" Subject: Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic' Message-ID: <20170418162822.GA2358@intel.com> References: <20170412205229.GA13659@intel.com> <20170412211931.GA15771@intel.com> <20170412214749.jyt7cmyhovivtb2m@pd.tnic> <20170412221639.5klmqk4mjbvy6btx@pd.tnic> <20170412222619.GA17839@intel.com> <20170412222925.r3izasv3yuyjy62e@pd.tnic> <20170413113159.rc32ebiswn64nzrr@pd.tnic> <20170413121215.kzflalrar7hpxvjh@pd.tnic> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170413121215.kzflalrar7hpxvjh@pd.tnic> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Borislav Petkov Cc: "linux-nvdimm@lists.01.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Thomas Gleixner List-ID: On Thu, Apr 13, 2017 at 02:12:16PM +0200, Borislav Petkov wrote: > On Thu, Apr 13, 2017 at 01:31:59PM +0200, Borislav Petkov wrote: > > @@ -321,18 +321,8 @@ static void __print_mce(struct mce *m) > > > > static void print_mce(struct mce *m) > > { > > - int ret = 0; > > - > > __print_mce(m); > > - > > - /* > > - * Print out human-readable details about the MCE error, > > - * (if the CPU has an implementation for that) > > - */ > > - ret = atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, m); > > - if (ret == NOTIFY_STOP) > > - return; > > - > > + mce_log(m); > > Actually, we don't need that call here because do_machine_check() > already does it. Yes. Don't add mce_log(m) here. We've already done it. With this change: Acked-by: Tony Luck -Tony _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753058AbdDRQ20 (ORCPT ); Tue, 18 Apr 2017 12:28:26 -0400 Received: from mga02.intel.com ([134.134.136.20]:38804 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750766AbdDRQ2X (ORCPT ); Tue, 18 Apr 2017 12:28:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,219,1488873600"; d="scan'208";a="90928347" Date: Tue, 18 Apr 2017 09:28:22 -0700 From: "Luck, Tony" To: Borislav Petkov Cc: Thomas Gleixner , Dan Williams , "Verma, Vishal L" , "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "ross.zwisler@linux.intel.com" , "x86@kernel.org" Subject: Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic' Message-ID: <20170418162822.GA2358@intel.com> References: <20170412205229.GA13659@intel.com> <20170412211931.GA15771@intel.com> <20170412214749.jyt7cmyhovivtb2m@pd.tnic> <20170412221639.5klmqk4mjbvy6btx@pd.tnic> <20170412222619.GA17839@intel.com> <20170412222925.r3izasv3yuyjy62e@pd.tnic> <20170413113159.rc32ebiswn64nzrr@pd.tnic> <20170413121215.kzflalrar7hpxvjh@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170413121215.kzflalrar7hpxvjh@pd.tnic> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 13, 2017 at 02:12:16PM +0200, Borislav Petkov wrote: > On Thu, Apr 13, 2017 at 01:31:59PM +0200, Borislav Petkov wrote: > > @@ -321,18 +321,8 @@ static void __print_mce(struct mce *m) > > > > static void print_mce(struct mce *m) > > { > > - int ret = 0; > > - > > __print_mce(m); > > - > > - /* > > - * Print out human-readable details about the MCE error, > > - * (if the CPU has an implementation for that) > > - */ > > - ret = atomic_notifier_call_chain(&x86_mce_decoder_chain, 0, m); > > - if (ret == NOTIFY_STOP) > > - return; > > - > > + mce_log(m); > > Actually, we don't need that call here because do_machine_check() > already does it. Yes. Don't add mce_log(m) here. We've already done it. With this change: Acked-by: Tony Luck -Tony