From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from LGEAMRELO12.lge.com ([156.147.23.52]:52820 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758755AbdDSBC3 (ORCPT ); Tue, 18 Apr 2017 21:02:29 -0400 Date: Wed, 19 Apr 2017 09:58:25 +0900 From: Minchan Kim To: CC: , , , , Subject: Re: Patch "zram: fix operator precedence to get offset" has been added to the 4.4-stable tree Message-ID: <20170419005825.GE19929@bbox> References: <149251978712756@kroah.com> MIME-Version: 1.0 In-Reply-To: <149251978712756@kroah.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: stable-owner@vger.kernel.org List-ID: Hello Greg, On Tue, Apr 18, 2017 at 02:49:47PM +0200, gregkh@linuxfoundation.org wrote: > > This is a note to let you know that I've just added the patch titled > > zram: fix operator precedence to get offset > > to the 4.4-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > zram-fix-operator-precedence-to-get-offset.patch > and it can be found in the queue-4.4 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let know about it. > > > From 4ca82dabc9fbf7bc5322aa54d802cb3cb7b125c5 Mon Sep 17 00:00:00 2001 > From: Minchan Kim > Date: Thu, 13 Apr 2017 14:56:35 -0700 > Subject: zram: fix operator precedence to get offset > > From: Minchan Kim > > commit 4ca82dabc9fbf7bc5322aa54d802cb3cb7b125c5 upstream. > > In zram_rw_page, the logic to get offset is wrong by operator precedence > (i.e., "<<" is higher than "&"). With wrong offset, zram can corrupt > the user's data. This patch fixes it. > > Fixes: 8c7f01025 ("zram: implement rw_page operation of zram") > Link: http://lkml.kernel.org/r/1492042622-12074-1-git-send-email-minchan@kernel.org > Signed-off-by: Minchan Kim > Cc: Sergey Senozhatsky > Signed-off-by: Andrew Morton > Signed-off-by: Linus Torvalds > Signed-off-by: Greg Kroah-Hartman After Linus merging this patch, I got realized that patch itself is correct but no need to apply this patch to the stable by review from Sergey. Sorry about the noise. Please drop this patch.