From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750950AbdDSEG2 (ORCPT ); Wed, 19 Apr 2017 00:06:28 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34640 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750742AbdDSEG0 (ORCPT ); Wed, 19 Apr 2017 00:06:26 -0400 Date: Tue, 18 Apr 2017 21:06:20 -0700 From: "Paul E. McKenney" To: Stephen Rothwell Cc: Linux-Next Mailing List , Linux Kernel Mailing List Subject: Re: linux-next: build failure after merge of the rcu tree Reply-To: paulmck@linux.vnet.ibm.com References: <20170419135016.259c2d59@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170419135016.259c2d59@canb.auug.org.au> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17041904-0036-0000-0000-000001E4DF6D X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006937; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00849434; UDB=6.00419437; IPR=6.00628074; BA=6.00005300; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015094; XFM=3.00000013; UTC=2017-04-19 04:06:23 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17041904-0037-0000-0000-00003FD1A20E Message-Id: <20170419040620.GI3956@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-19_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1704190038 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 19, 2017 at 01:50:16PM +1000, Stephen Rothwell wrote: > Hi Paul, > > After merging the rcu tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > kernel/rcu/rcutorture.c: In function 'rcu_torture_stats_print': > kernel/rcu/rcutorture.c:1369:3: error: implicit declaration of function 'srcutorture_get_gp_data' [-Werror=implicit-function-declaration] > srcutorture_get_gp_data(cur_ops->ttype, srcu_ctlp, > ^ > > Caused by commit > > b4d55cac0a93 ("srcu: Make rcutorture writer stalls print SRCU GP state") > > This config has CONFIG_CLASSIC_SRCU=y and CONFIG_RCU_TORTURE_TEST=m, so > CONFIG_RCU_TORTURE_TEST is not defined - CONFIG_RCU_TORTURE_TEST_MODULE > is defined. You probably want to protect srcutorture_get_gp_data() with > IS_ENABLED(CONFIG_RCU_TORTURE_TEST) instead. > > I have used the rcu tree from next-20170418 for today. Please accept my apologies! I forgot about the state of -rcu while chasing another bug, and only a few minutes ago made the transition from "Why doesn't this code work?" to "Why didn't my brain work?". :-/ Will be fixed for tomorrow's -next. Or at least broken in a more subtle and creative way. ;-) Thanx, Paul