From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966095AbdDSQU4 (ORCPT ); Wed, 19 Apr 2017 12:20:56 -0400 Received: from mail-db5eur01on0122.outbound.protection.outlook.com ([104.47.2.122]:45024 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965949AbdDSQUu (ORCPT ); Wed, 19 Apr 2017 12:20:50 -0400 Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=virtuozzo.com; Date: Wed, 19 Apr 2017 09:20:27 -0700 From: Andrei Vagin To: Keith Busch CC: , Thomas Gleixner , Xiaolong Ye Subject: Re: irq/affinity: Fix extra vecs calculation Message-ID: <20170419162027.GA7428@outlook.office365.com> References: <1492104492-19943-1-git-send-email-keith.busch@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-r" Content-Disposition: inline In-Reply-To: <1492104492-19943-1-git-send-email-keith.busch@intel.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-Originating-IP: [207.91.133.9] X-ClientProxiedBy: MWHPR10CA0001.namprd10.prod.outlook.com (10.172.48.11) To HE1PR0801MB1980.eurprd08.prod.outlook.com (10.168.94.150) X-MS-Office365-Filtering-Correlation-Id: 648ea2d3-3f84-40c0-8b17-08d487400650 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:HE1PR0801MB1980; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1980;3:LeYiHK2mZTC47f0PLUAr4hKUkWy305ij5Wr3sTp76hT+BcB88r9XBrWRTjN12ivn2h6x/ficTJCcRrl0DpmM7RwtlDclE20vxitrf+SsShg0hrZdhHrygK6YkexI463eTV6JSbwm7hqQ2zFLF8zbatNx9vy4V40ENoBKJP0+ipwzPMUtaU3ouqBprnFo8eVKhlaYHNJzcfToLb4AFW2aWNDSzVrOkTHzXRtcGvZViURvq4aVJL87hsR+fR1pKopx5R4kxlCU/2uhqvSdNaWdjcj4wh3KuCrZ479nnKSNN6PqoXxRvoVIOVHMIB4nEB3bSI+Z+8mKUmTnQDzUMEOqcA==;25:59USqLet5RC8mxW9Ak/Y1u9E0GJYecP4m2+WDMjPMLYOCfVPW3+nh7+En+SC0Kge4TzfWBoE3mpaKcmLtghkrVwOQnlq5VeWGf9PTxQUucU1rVBMo+NczAyfSmMihSLuSuM7m1De5BRdtmPi+N6UgIcJWAeUVq6i8YVRG/4q5oqy4JwqfcwyOIKVyAmVXE/ZwUmgXeQAmEymjBjCIQhjrNGl1zQ4eRuiwFIx/pvuQmi//6/sXwjtSi7CqoUszkaYwzvhjMSr3CJUs1NvNhIJagUgl50xxHngGffJ8/HmlYIRQKuNAQKvnDkOJLTypcXipt5dubK/S/zdT9dyQMc8k3o9A2qwN6vkX17WdwSg4/MV02Aw7DFJGAXlp0mpb3Yg5PVFlIEIexVr5eDWIum9uLFaaguAYL2NFykywSNpocxVzCiDGzgoeoUD9k/X+Frz X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1980;31:WtiPCEO8QrWrVl3YIwAtSz00IRny8DYy3vc/lIR4AbJl+oo5pIc0VCz33O1zpv6em53O5ANevXMymdDTIQKahfXh12kucBN/xZRR+z7+Ao8HAxbLoEtxr3KOixr5ChfCv4G3JkfpYz+TE3n5TZ/+CJ1VQptx2OIRFk/OxYxPmW/+cK+f+1aq9gSXG6pqkdEbE/Uo3FS1InKATSXAtd93RI0Bxg6HFiDnPLXP2zxVCucYG1wI9FbZ4BQ5V/tcqeZd;20:BcWfE1Uxy7645y8hP7uJ4tDw+IpLUnGdpC5FYZakc5ZekdIMo/YJo8EIZj3/HW6FCwkEus5UpBpZ+IzCeT5kriMGy7JNwKUUUi3MlrId/AytwzpfJsw+lP5QoEAitYpNZo8eW7PhicCZ9N2Jwtdh3V3N1qeDyd4nNHNTwxHFycoYLER5d8t3GLQomJmlcj9DSEXz7ccJbzvBXCTfxgeAfOmpEKk6zKWjBHTufwEDTqi0dNNl1zdQkjbmZhv3Y5og/QmFv3MK9DvlpwOBr7c8LCrlGyalbBpElUqQ0rSNkaebVRNXy2wsCUekCI+w+GxKwam6gEv1NYgxUSyv4sqw9aSulwSx46wnxl7s5772gdMDaQM2vCWutjLZ798tsAHqJoaWEVuzi2lZCn21RjO7VFXWiGnWbOMEEyHmZL3cj1c= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123564025)(20161123562025)(6072148);SRVR:HE1PR0801MB1980;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1980; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1980;4:twGuKYv0NCXfRzSvH2N7/+4JZXFzBK8suIN+h7VQOGV5zT+O5Yh/3hOWuQHiyF3meAesvXtjecWHTLfUDZ/lyVS2s0r4qlpgjv12rez6Tqh+2ZgtIKMuSC2QehtJNupg4E+ajHtNyrXN47peqQiV47psRaeWIqdxr91ljwWTMGX6xne13/EQUzD3qXJceKV+dcczP9lJeB0woAh1gnTW53mzV2jDmf5A5zIrlmw8Bq8Gpj5vdH7WTRtbQNbMsbK1Xrr2ENIGKpZLBqeLGtItqZb656bGzJ20zZFfTEUulClChvxKdB2gY+g9UdITo+JYlk9J0gpD54MB+byjyGQ37GuoAku+I3RW3n1nG/LEzxWtcFHAMA1ARPrT9BFSAmyPHPP4eeNLPbauw8JnKq7Lj7jgUtv1HdFwpikVvkBaQ+S4tRGAxaMiSG6PU8lqRXDs1AuupAY20ccqL4xDLuugL7H1tkwtD4PPALa0f7xQonDgov0zbzTNik3KFkWnedb9eiSBJpv82HGx0RlujB5Z9ux3sF+IYBYAtoWBAnFys/eUOgL8GYUWy/m6SdyUOABq+tvtx7zkWz0gcmU+RF2SlE2Gnauze0EJh1gR9T8QvmS09SEdAyTCFIQBAtAS9ruwlMcPWmqQolUV1LyTiR9HAxHtISIbeK3mxTKdwdtkM1BcNEztoIzl7UkFKk4/hbm0PBzA4ej4ki8/5CJX06N2C5fv3GAMZReit8nhJJzCrvGxF92s/mHQdWYtlDj7i/dc X-Forefront-PRVS: 028256169F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(39450400003)(39400400002)(39830400002)(39410400002)(24454002)(50466002)(1076002)(42186005)(3846002)(81166006)(189998001)(8676002)(305945005)(33656002)(4001350100001)(110136004)(38730400002)(5660300001)(53416004)(6116002)(54356999)(50986999)(76176999)(229853002)(6506006)(23686003)(83506001)(2906002)(47776003)(9686003)(55016002)(6306002)(6246003)(66066001)(53936002)(54906002)(86362001)(2950100002)(25786009)(4326008)(6916009)(6666003)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB1980;H:outlook.office365.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?koi8-r?Q?1;HE1PR0801MB1980;23:tThvblmgTDoWiVkEcUvIMyu72W+YBxT+qKrSm117b?= =?koi8-r?Q?SpGntQRc33F6F7HXnU18fQjhunVLpqep6QxxoiBOBKZTFuLo9LmXkwi9JZiEVb?= =?koi8-r?Q?D3gz9SHkcXC9JpKe7F+E07dHI/K4tHTJw5FfscI/yBs2aizYxIAcMn+2L1FUG8?= =?koi8-r?Q?PkVPrU82+esIdDHAZ+zHSWaSd91xBCXLxSvNYCyUQVd/98fZcAWUN6XdzUN1tQ?= =?koi8-r?Q?nvweWtCmsqpgU6K7VmFpSycSmneI/jl8bx6lYFwYe3fwSbfRr3lIWMZB29YfM2?= =?koi8-r?Q?QAqj1/tw+kd6JQtOY2TRZ25ncmGJhss6MpPgyM42rJCnR6CtLYgZ0Qv5J3F/Bo?= =?koi8-r?Q?w0ZpO5FOtTggaEkhGc48LttEVnbbWBYT8re+h7ZL+FjHttBvNQ359UVafFE439?= =?koi8-r?Q?Vu/0mEz53OVLXG0Meg8vRhypBaOcrAwrgpscclnR6vlHQVojsCCwwFa3QrIa2j?= =?koi8-r?Q?svfSMDSSfCflBsyQxCKgolhWQClNFIRyTv3Kr7MXI6RxqYHd4f0J2TmMfoSpS/?= =?koi8-r?Q?kws0GQJckgrU5pmCBzbc7kjULob18ZsQXWKqQdDSlY0BLff45hifs8ZTBx9HHL?= =?koi8-r?Q?t4dLPCcJoyjGgrMpqfAB3cgd0o1M5UWKTZBNAI/GU60UuaPU2Ft/32EccA1aRz?= =?koi8-r?Q?00vNJWGgfnL4oX+OQq/HOfGDYejfVyGbrDh4shjuYA2Ebmt5+ef8U7OVVNLYlG?= =?koi8-r?Q?H0OIaKiY1JnDwLeE4TNyKMsapaXy6peVr7mvG1gO/+vjh262JXHw6SfVxKKsMa?= =?koi8-r?Q?V5a0Yki81Q/OrIw92QJ9mkhZzwF1sQeIIwfZUPhEKQmEzJTQfSCvq98pr+JX4Z?= =?koi8-r?Q?bKonPHXVSZUI+tC3miQRgcFlqyy7AIFELPsC72O1kf7j0p0AbMSuIc5d8FGGlf?= =?koi8-r?Q?Q0ZHKMOY7a+DaGc5vy19q0BRbm5y56lfsKHlZTGD4FILkcbJyd5bzMhmqg/AI1?= =?koi8-r?Q?JCjWXR9IgRxU2qaC4Kyx0oW8wQtZ3YidYqEgaZ7Jm+26oKnndHCezvC8PlWbEt?= =?koi8-r?Q?1mtzwTl8gXABEc+c59/9MNHEQBLNxtDAQsDG5zBCg6YF0lXN7KvxBRh4UPj+Si?= =?koi8-r?Q?kK/lXb2/XPNGnU7NEcTxUgvs3/r1xoev95cM=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1980;6:8xwjXFvolQCHFcWd8VoQK8nvfP6tl0/6YlI/Rt03P8eLuffEwGvM3Co5kuogQIGQeZA9/p3l8mwNkcFmiLiOcPsJg78y6s4N0x1tGGhTAsgPPEJAMEMCoEt3ZIc2m34IKrGv0JhprahOGCsqKNqzHDimHWL1pPfjFEfgGa+G/PcFtDz4W1uoyJGe1/p5u5PD7J1klYW5Og2mOpdwqUpirdJbMXpyswyWwMtwDgJqD4wYF15FnWYLxAlVh3s1ZUfHsGC8S5z89ww2hrojKq8YhFiiHERKSHsZkO/biperXjHOxcudc1kSVq1mjt8ypV7RicTIqaSgfzJqHzsqO1DtAe3s6IQKLQYoDeH60Ddb8b4WpsXAvNOPXzTbeu+5vo4rMJTlcuIcdobvOB79mc6KydZkwKXgiXFmO9LsxzgdW1yhx06xYkxVKfCt/l/pG2WGzCTiBTn13JSlXqc8AIO+38b7wHVnN0sGUC1+dzdigOVnuqBiDOYjgkmn7oYedE1Tx0VYOB3/7xwZu3dnW4B+Qg==;5:5/4CDPLzIErPGlzLw9D6WRmdx+q+jTLEBlWIFR7WF47Q1lwj4sZPgZiAeFok+TeBKmnEVMeqDadW9EM7gpIaVaQdMMInhF+DmrAtETv0EYlyaLum7ZtSSvl5vjF79RuHp/WfyEan05dmENfx6e8WnQ==;24:zBA7b0kJ2Z3kj8inlKLhRpeP2IICcbwS1b2Wqe6i/fZg6/aAWyu5U3N4jFI/iCuKVEG3+1djRIOFD3ARni4EtQiSASPDdyNUyFuxSGoSMCo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1980;7:z/RTsujrqKNzBnLSArNb6pvsy8t7M7kC6JrNxh6SHwgjXrl5dEdjsyCnZoi5p33waU1i2Quf4AMGPzkLNk8nvSB3Efni2yEmz5Ll3TEQXxEuft3ZLj2PPgT38bXkQo4kkNyvqE3X/QlR95VoXIWoAWNky7iHAwvqfwiFvsoEHrjKORt6NYlYycWvymBTF1J0e0/uQupmUH+HZMy1hGZ2GIXE59ghTmlLCiKqLd3vTmJm+hKuKVLaApwz0NcjcGi+f7UJ1lk5oXL/Vfi96Q7se1CBbuydk/oIuUQ5BLdeth5GzB8zUDB3whNS9TSs2U7fhGmQDqo/SkHrzkR6WDFb8g==;20:MlSUnEbU78ZpXwib4G14k1bOup2kGJc/9GpMhoVZBJGd5xQ34xTvDDQAJ3ahG7wyFTYebqc0vJ2rthXucB8c0VqcjfEMvcZpJR4NG93dRhTHVFC9BckKIfOl46nhmpWifjapP2bk2L/53Ffy5nJu7zc4t+omz1cembj0KKgpxuA= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2017 16:20:39.4690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1980 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Something is wrong with this patch. We run CRIU tests for upstream kernels. And we found that a kernel with this patch can't be booted. https://travis-ci.org/avagin/linux/builds/223557750 We don't have access to console logs and I can't reproduce this issue on my nodes. I tired to revert this patch and everything works as expected. https://travis-ci.org/avagin/linux/builds/223594172 Here is another report about this patch https://lkml.org/lkml/2017/4/16/344 Thanks, Andrei On Thu, Apr 13, 2017 at 01:28:12PM -0400, Keith Busch wrote: > This fixes a math error calculating the extra_vecs. The error assumed > only 1 cpu per vector, but the value needs to account for the actual > number of cpus per vector in order to get the correct remainder for > extra CPU assignment. > > Fixes: 7bf8222b9bd0 ("irq/affinity: Fix CPU spread for unbalanced nodes") > Reported-by: Xiaolong Ye > Signed-off-by: Keith Busch > --- > kernel/irq/affinity.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c > index dc52911..d052947 100644 > --- a/kernel/irq/affinity.c > +++ b/kernel/irq/affinity.c > @@ -108,7 +108,7 @@ irq_create_affinity_masks(int nvecs, const struct irq_affinity *affd) > vecs_to_assign = min(vecs_per_node, ncpus); > > /* Account for rounding errors */ > - extra_vecs = ncpus - vecs_to_assign; > + extra_vecs = ncpus - vecs_to_assign * (ncpus / vecs_to_assign); > > for (v = 0; curvec < last_affv && v < vecs_to_assign; > curvec++, v++) {