All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
To: netdev@vger.kernel.org
Cc: brking@linux.vnet.ibm.com, jallen@linux.vnet.ibm.com,
	muvic@linux.vnet.ibm.com, tlfalcon@linux.vnet.ibm.com
Subject: [PATCH net-next 04/10] ibmvnic: Fixup atomic API usage
Date: Wed, 19 Apr 2017 13:44:47 -0400	[thread overview]
Message-ID: <20170419174446.37372.33815.stgit@ltcalpine2-lp23.aus.stglabs.ibm.com> (raw)
In-Reply-To: <20170419174015.37372.48544.stgit@ltcalpine2-lp23.aus.stglabs.ibm.com>

From: Brian King <brking@linux.vnet.ibm.com>

Replace a couple of modifications of an atomic followed
by a read of the atomic, which is no longer atomic, to
use atomic_XX_return variants to avoid race conditions.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
---
 drivers/net/ethernet/ibm/ibmvnic.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index c10bae7..b5871df 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -962,9 +962,8 @@ static int ibmvnic_xmit(struct sk_buff *skb, struct net_device *netdev)
 		goto out;
 	}
 
-	atomic_inc(&tx_scrq->used);
-
-	if (atomic_read(&tx_scrq->used) >= adapter->req_tx_entries_per_subcrq) {
+	if (atomic_inc_return(&tx_scrq->used)
+					>= adapter->req_tx_entries_per_subcrq) {
 		netdev_info(netdev, "Stopping queue %d\n", queue_num);
 		netif_stop_subqueue(netdev, queue_num);
 	}
@@ -1499,9 +1498,8 @@ static int ibmvnic_complete_tx(struct ibmvnic_adapter *adapter,
 			}
 
 			if (txbuff->last_frag) {
-				atomic_dec(&scrq->used);
-
-				if (atomic_read(&scrq->used) <=
+				if (atomic_sub_return(next->tx_comp.num_comps,
+						      &scrq->used) <=
 				    (adapter->req_tx_entries_per_subcrq / 2) &&
 				    netif_subqueue_stopped(adapter->netdev,
 							   txbuff->skb)) {

  parent reply	other threads:[~2017-04-19 13:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 17:44 [PATCH net-next 00/10] ibmvnic: Updates and bug fixes Nathan Fontenot
2017-04-19 17:44 ` [PATCH net-next 01/10] ibmvnic: Report errors when failing to release sub-crqs Nathan Fontenot
2017-04-19 17:44 ` [PATCH net-next 02/10] ibmvnic: Fix ibmvnic_change_mac_addr struct format Nathan Fontenot
2017-04-19 17:44 ` [PATCH net-next 03/10] ibmvnic: Unmap longer term buffer before free Nathan Fontenot
2017-04-19 17:44 ` Nathan Fontenot [this message]
2017-04-19 17:44 ` [PATCH net-next 05/10] ibmvnic: Do not disable IRQ after scheduling tasklet Nathan Fontenot
2017-04-19 17:44 ` [PATCH net-next 06/10] ibmvnic: Remove inflight list Nathan Fontenot
2017-04-19 17:45 ` [PATCH net-next 07/10] ibmvnic: Correct crq and resource releasing Nathan Fontenot
2017-04-19 17:45 ` [PATCH net-next 08/10] ibmvnic: Disable irq prior to close Nathan Fontenot
2017-04-19 17:45 ` [PATCH net-next 09/10] ibmvnic: Allocate zero-filled memory for sub crqs Nathan Fontenot
2017-04-19 17:45 ` [PATCH net-next 10/10] ibmvnic: Remove unused bouce buffer Nathan Fontenot
2017-04-21 17:45 ` [PATCH net-next 00/10] ibmvnic: Updates and bug fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170419174446.37372.33815.stgit@ltcalpine2-lp23.aus.stglabs.ibm.com \
    --to=nfont@linux.vnet.ibm.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=jallen@linux.vnet.ibm.com \
    --cc=muvic@linux.vnet.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=tlfalcon@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.