From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969225AbdDSTMO (ORCPT ); Wed, 19 Apr 2017 15:12:14 -0400 Received: from mail-he1eur01on0139.outbound.protection.outlook.com ([104.47.0.139]:61152 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S968021AbdDSTML (ORCPT ); Wed, 19 Apr 2017 15:12:11 -0400 Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=virtuozzo.com; Date: Wed, 19 Apr 2017 12:11:57 -0700 From: Andrei Vagin To: Keith Busch CC: , Thomas Gleixner , Xiaolong Ye Subject: Re: irq/affinity: Fix extra vecs calculation Message-ID: <20170419191156.GA13017@outlook.office365.com> References: <1492104492-19943-1-git-send-email-keith.busch@intel.com> <20170419162027.GA7428@outlook.office365.com> <20170419170359.GE16224@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-r" Content-Disposition: inline In-Reply-To: <20170419170359.GE16224@localhost.localdomain> User-Agent: Mutt/1.8.0 (2017-02-23) X-Originating-IP: [207.91.133.10] X-ClientProxiedBy: BN6PR03CA0039.namprd03.prod.outlook.com (10.175.124.25) To VI1PR0801MB1983.eurprd08.prod.outlook.com (10.173.74.16) X-MS-Office365-Filtering-Correlation-Id: 3e9f664c-7eee-42b1-2a58-08d48757f891 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:VI1PR0801MB1983; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1983;3:wUOOmIYgWIMd9aG2LzbjL7h4duIfINqUllYAF00T2jkTFvJw9HxyPrp9zmIBlV+vdidW5U0yuyBw+ef2iVEJZ+05VOcTo1bNyxf3yFbxYJQfsIUtZ4NJZuJ3DamFnZLHbVOlID2vNYkoceaYgqPt8VJcR8+kU7iOZICJku1g2qsF3e7MhleC6NYp0zc5lQJboycnSIGH72NeIwqmRMm8zki3cNXOL8TcKBdJls/VVgGPMkqxpwHUfUtyGQ+JW+0WuAQ73ndN1P0bCxhTVl9fpFaqSUy0BfKBCi+S6AvNcHzI1eKuFx6d1kMRiNZVaMPpHsc/ySOK/l5pHyHOiDx6Sg==;25:Y0JsX2Lg0yhni1/t4xPfpHpLg/foK2QFoz4fTr1tL5Ccn6c6at27d0R3sWaJIieSwpOV3PyPifZlls1m57eZVQbi3UyCLC4XG1xqeT7rNP6bOShI4+VKUm8Q4hk0Q/qXDLWAeUavys1s3n8JuKXylrgdMHjneUG9b14z+RSUykq6qyk4isoOHAimdN9nGuNp0GKtpa5k1rtHLQfNrTr0jK5XaAzv9vq/QH1R7kO73iIp+wuHNJT6fe9VE0ndxlzWayGK5Y1PeKZaJ4hbnB4wDfgKiX/EpLIgI+fIogjkn0L2PQAJbjtsXoLvk0ROivs+R/DwfM8FGDwxakxqps82vP+VqzWDT04FfWflBJhfGsetbqXsUV/oMYaHJ9WfbR8Iu3vtuY+o2if0eL7KUbtJ+E2p+ViaWBtWQ5uqW1C99ReSSJxoNVsx7NFE/tS5az5I7d7HP+6Ukn/xThbA6HtcVQ== X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1983;31:mknFqW4QBiy0p/xnGPo7Myeg1hBp8iLkab0t8ei8BMmjlnYP/j2Qdpr6Unbh4teqCVReEubm8euMTlwICVIxgFNLpsSftrJUFYO/ZqEbd9FD88AMw6w/I8MjS81ZK1RSOhqcPrLboHDIenoXon8Wff+zPd7jp8+VNTiB3eeIuR/qfKYI+WwStbjnWNc4K+q0rsNAbbL3EB1WhdHJhMjw2xzKL78UwvYokBF1gAdAoXvDOHMvyIURhwq55cfd/udlntKJmdgKoZZ+CKL7gLMEMg==;20:LH2fDly8sCh+OhnvOl++ZZozXh62EUBjiNosWkfLxqP7kKscMduAgFlpqVjfWjfw5CENNFcWoEATx0DIXJuyDWVve1PDZGouhyxzwIZWb0xyJP/uoiEhm64W6oB78/l5vjc8KPLbpXO8A5ABLuSlnUIX83LW2N5LiPEO+ufHJSIf/BWQePNbz8wZOTfe/oE4M/FUXbt0179xxqwHHtkxCDaS1ZAmHvrKvYcTmscAKavEzmjns+CjhNptPlhsnhiHMrlMnJ85dSuZ0uDHeo92DuIwXsD6sLphZK7xxQqS6/R2vZnAunwzXtISWlh4ppta3wynka8xsiNlWpgF9nqNonqHy2HPwbOg7d5PsWAOSXi5maTI/QcTwIHUkWZClVaFF8AWXxsOLRYWzD2js0GsF6BMnq9OKkFZa4X997GS4Ds= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(20161123564025)(20161123555025)(6072148);SRVR:VI1PR0801MB1983;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1983; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1983;4:MSKU0Ar7tKZUjfUar+DQhd8ZIamZjrUHsZfsMv5ladnA0y59hFP+Kye9G9iyhbpxflelxraIb8FSJGn3PK5UXMiYHIQMD1L3fMqXX2bZDuLFU1O85YWXZd/nbYfJ9hVUTXhrtcZrkAvfu5X89ACfbZcZkLjw0ExF3/jVtRdecNSOJFWrR1YBja2DJfFrIxZxQMxcEYEnVxJECZdx0zp8vp9F4MhtNNC+1D3Ly7ETai0xU/rK2SfqgT/+ZLtDI9CUkSsASRAFs5rlsOy5tWeTfLL5fe4vNy9mB2TQqkVlVqdwW1kP3ZV1g3nRLnB4t0+GzGgC9lZWWkvvdPgXy8nQgZTJqEiCpJxgtDpUO/LGIhcPehV8tAiOpRsL8K4bvK0P7XNLw6PZp///NXE19EgJgnGsRQ79pSnAC9Ld9TNUI8EaFD1xEjpMx1w+0iFpwh/mdDDCxGt4NgjY3e27Z2ynQFWrEkuPJDC/SqgFQwyiPLz8UqxiTZynCV6EiONaSc93OqY4UZ0MdEwsnSvmbf9aNDOeK07jKzh1K5+fY/Wor1rBlaDKaabfbX5pTXfnTx8SfmF+3q9RnMBeiR2lkHlSxJp7eF35Uy4JiQboEZXLsBgBlUmfllmDF9Xg3U5d6xDEDY/PM6I3SjWuqpWH1mhvEQOr+bA2CPpFkN5wvQFOfwVWTfrDFQ9392ensCwppdKGKmKwck2xYmkIA/5ZnYezoA== X-Forefront-PRVS: 028256169F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(39400400002)(39410400002)(39830400002)(39450400003)(24454002)(83506001)(8676002)(81166006)(4001350100001)(42186005)(2906002)(53416004)(55016002)(3846002)(66066001)(1076002)(86362001)(6506006)(23686003)(6116002)(6246003)(6306002)(5660300001)(9686003)(6666003)(53936002)(54906002)(38730400002)(54356999)(33656002)(4326008)(229853002)(25786009)(47776003)(110136004)(76176999)(6916009)(7736002)(189998001)(2950100002)(305945005)(50466002)(50986999)(18370500001)(26326002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0801MB1983;H:outlook.office365.com;FPR:;SPF:None;MLV:nov;PTR:InfoNoRecords;LANG:en; X-Microsoft-Exchange-Diagnostics: =?koi8-r?Q?1;VI1PR0801MB1983;23:zQyKe/2aSjAB7M2FdD26zRofBeZ3QISRnctjjP95C?= =?koi8-r?Q?T9ByX2cN03GJNOuSUf98LoVY1HBTnayVJm0ygBjlnDH9ptFsGD6j4v9hOfxD0F?= =?koi8-r?Q?2UXpvMblP0IUUNyjJyayhvGme9zFk3iYCS/mIWyOXoqowOC0Zhj0oyU1TI+g7S?= =?koi8-r?Q?TVr6t+Mu3pxUAx/9nMWu/B9UmiT9EeSS5QqGyeQT5n6r8nh+PMEsNfFbTbK9jC?= =?koi8-r?Q?yD9UvZst07buJDFvlhT7XYD+JC0zpSE+VMd5BXIswObnJvUm15yrd+553lN+WG?= =?koi8-r?Q?SmS/+taduudHau8z4UuaF5YmluRWnOfum7OVbdP9JPHXh6lFSNmSWO/i2KM1z/?= =?koi8-r?Q?vyt8rm/oiqZ2Xgoa8AqcZik5vyrdiIou6m6EN4G7YM8VahjRVC0fBAEi7toqYv?= =?koi8-r?Q?TaU3amo0grevzzm46j4BFqod+rTEoUD1fMNL0WP26IJ8W1UIkHHrqPfLqwlb1j?= =?koi8-r?Q?b6+HpXlQCwbflyc6djCvWppEOEPimst8ihlhJegmKTBCIPYrL5hsH7N5TsQmhT?= =?koi8-r?Q?Fq5N6CJDA/X5GsrAgX/Moo24uQ7qZs+2tdxsl5DQhv+EHJqjGLMgWX+odGVUSr?= =?koi8-r?Q?y/3nqbXcZqTD3O5LbeZb/abNbKgH8gxws4DcZB9QRxPJ8QhGYDYtiWpCZ/RLiX?= =?koi8-r?Q?ffZTnUICQHyFFf61eZGZCjOms5ViTe+dKXnYbSXXNkqy3DDKNdYEPYmXL17rwm?= =?koi8-r?Q?YrG+VcMTAYYmGiJQEY6spfJN2ZfWoVztBbgGFAZKCP+wmZQ0juabWJSuZNucCf?= =?koi8-r?Q?1hhz1F1RkQc93fKhr5jcRoOHOacswHZcVp2ax4D8CdBTBhUz9EcDqBzRq5OXsq?= =?koi8-r?Q?LQAGRaxBLo+AXNqemQRIoMs8skPV/9/y62ZNTvUMbyy2IeE2jMwgWE3r4PWjvP?= =?koi8-r?Q?NM9aqUDu0ao0W1livlHsxeI5olhKtRbFBa7ytKkSs1M1j9rKrUk3X3S6yfW1pb?= =?koi8-r?Q?Wmv5mpA6/ZtM6lZgS3/Vl7iY/CIbHC8QSBVBTplOpHuxdleQr5rzR3F1eJNwjw?= =?koi8-r?Q?xSE7qFNVwVOHZp0HH1WiGAv+WQRwfGYbTXT32QFlfjUXUtmuTqV17NdS7zU9eC?= =?koi8-r?Q?xePQTbWnnZbvZ6xXlm80gxBZnC3hhS+h/SXHDLQ6PWL8+eJ/SjL8kCxNtVcltq?= =?koi8-r?Q?f+AHFNks3d6g1sTfw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1983;6:E31pjlkaLFFuKO0IxdVEmqefUgePGI5XGBRHO0qJ3j5ayqNWIOxCZNcOHbk6RdUDkiYLcGeghQfvESIQyL2LfImp6s5o5MBoGn5VowDuqxe2f6NAwdD+vlXm8YZ+6Et0rtXMqZto35x0IfKd1/DaJpn/e/qyUMUebCuJI+JsES4uzAY+kifQ3vGstI44hynuvh9sXJvdo+4EFsDimRfhkCsMuo2UlXcQ0iCD0T2u2ucd1+xPEg3S4JsMZj7a6ar4oUXB3BXFKglSetsQa9eUjDSHMEbp859oGIzciffo8PF8xQwTI09PcKr4oH7C7363XJ/jv8Cs1ziUFyGFfdtSrJg9nd5EVwIUljGjNImpkx2E59+2LbafWnwueqibrYUL3yHRqm2yQEOnXnHKJOGG1Ru2kOMREE9dts3TpebYp9Bb4TbuYEc7peAs1DdxOsS/1GLFnJ7u5fzNbkykkd+4sA==;5:rMInzNNGyAN6GLqlveb5gq68xJ55IDzcWA6vf6NVJX5qiZa88NB07Wi6MKtRkQu90s8QBDwRYQME0Pqc5BCH/fI/bTKHcml36C/jeXXDNwhSLFcUecPWS3XrEQ/Ugnq7A/WMAMOxbfKto4ZFq4qm9A==;24:jDltq++xKk5CQ6pCUKAaPhcaycTGrL6lLrKU/BI+1qUjYq9ztyRqpGpWS37edSDbnKQAs4wHUwL3ENPpYIfqa1FWrsnZXoe6M7DRQy8MjQQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1983;7:e5e9W1V2l1bN+WqATN6aCWhisFdj387O++CUCckcn6sBPBLx0shnSiwp1yEtNezS0j1MSZPupd/6jJ5WYUJgwwjUyt0rSBm6aPzre7BKvPi9k2KpbLD2R6r3t7gqaFgMF+eh5KYIx1UQwZv31mdQ6RHUJZGck5zHmZy8D3E+0x5dUOL4sUIk3DWJGZAme3vOv4cfOB7BwWqwzCjaXxZWisJ4Kb5mXTcdCaGLgW6c+QHwcXPHhxVyvTp50t9tAJd7BvhmlH6C8QY6Mkh/BHWI0fZnXBFSSgQ6ErhN0oVT+kE3+75MhpPwJFHjsO6WzdqdMDG+eJmewc1j98bpjVFGUQ==;20:tWVzkMTxyxVJQ8J1St+hYoTsnvO4yzMRIwGuq40kL0ZaN/iM8hDzgNizqPUN1nOwe++oH65j22skOGmR5xGPkb8Vity8OPzPYJxszC67+wKA4xYgAJ00zVCdzXQ3UWpjgl3zLk0mmnnptlIhy4CcCGyd0jvr48hUEi3HcCINIrk= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2017 19:12:05.5799 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1983 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 19, 2017 at 01:03:59PM -0400, Keith Busch wrote: > On Wed, Apr 19, 2017 at 09:20:27AM -0700, Andrei Vagin wrote: > > Hi, > > > > Something is wrong with this patch. We run CRIU tests for upstream kernels. > > And we found that a kernel with this patch can't be booted. > > > > https://travis-ci.org/avagin/linux/builds/223557750 > > > > We don't have access to console logs and I can't reproduce this issue on > > my nodes. I tired to revert this patch and everything works as expected. > > > > https://travis-ci.org/avagin/linux/builds/223594172 > > > > Here is another report about this patch > > https://lkml.org/lkml/2017/4/16/344 > > Yikes, okay, I've made a mistake somewhere. Sorry about that, I will > look into this ASAP. Thank you > > If it's a divide by 0 as your last link indicates, that must mean there > are possible nodes, but have no CPUs, and those should be skipped. If > that's the case, the following should fix it, but I'm going to do some > more qemu testing with various CPU topologies to confirm. This patch doesn't fix my problem https://travis-ci.org/avagin/linux/builds/223674690 > > --- > diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c > index d052947..80c45d0 100644 > --- a/kernel/irq/affinity.c > +++ b/kernel/irq/affinity.c > @@ -105,6 +105,9 @@ irq_create_affinity_masks(int nvecs, const struct irq_affinity *affd) > > /* Calculate the number of cpus per vector */ > ncpus = cpumask_weight(nmsk); > + if (!ncpus) > + continue; > + > vecs_to_assign = min(vecs_per_node, ncpus); > > /* Account for rounding errors */ > --