From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Frank Subject: Re: [PATCH v3 1/2] ACPI: video: get rid of magic numbers and use enum instead Date: Wed, 19 Apr 2017 22:44:54 +0300 Message-ID: <20170419194453.GA23107@dimon-t520> References: <20170418123558.12436-1-mail@dmitryfrank.com> <20170419103618.20939-1-mail@dmitryfrank.com> <20170419103618.20939-2-mail@dmitryfrank.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from forward14j.cmail.yandex.net ([5.255.227.178]:37091 "EHLO forward14j.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935744AbdDSTpD (ORCPT ); Wed, 19 Apr 2017 15:45:03 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Zhang Rui , Len Brown , Felipe Contreras , ACPI Devel Maling List Hi Rafael, On 04/19, Rafael J. Wysocki wrote: > On Wed, Apr 19, 2017 at 12:36 PM, Dmitry Frank wrote: > > The first two items in the _BCL method response are special: > > > > - Level when machine has full power > > - Level when machine is on batteries > > - .... actual supported levels go there .... > > > > So this commits adds an enum and uses its descriptive elements > > throughout the code, instead of magic numbers. > > > > Signed-off-by: Dmitry Frank > > Are there any differences between this and the previous version of the > patch you posted? > No; this patch is identical in both v2 and v3 patchsets. Differences between v3 and v2 are as follows: In v3 I removed the middle patch (which was renaming the global flag device_id_scheme), and also amended the last patch: added the comment for that flag. Everything else is identical. Thanks, Dmitry