From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:45262 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936820AbdDSUVh (ORCPT ); Wed, 19 Apr 2017 16:21:37 -0400 Date: Wed, 19 Apr 2017 15:21:31 -0500 From: Bill O'Donnell Subject: Re: [PATCH V2] xfs: remove use of do_div with 32-bit dividend in quota debug code Message-ID: <20170419202131.GA12343@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eric Sandeen Cc: Eric Sandeen , linux-xfs On Wed, Apr 19, 2017 at 02:41:07PM -0500, Eric Sandeen wrote: > The kbuild test robot caught this; in debug code we have another > caller of do_div with a 32-bit dividend (j) which is caught now > that we are using the kernel-supplied do_div. > > None of the values used here are 64-bit; just use simple division. > > Signed-off-by: Eric Sandeen looks even better now ;) Reviewed-by: Bill O'Donnell > --- > > V2: now with less actual 64-bit division! > > diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c > index b669b12..6b42db4 100644 > --- a/fs/xfs/xfs_qm.c > +++ b/fs/xfs/xfs_qm.c > @@ -851,8 +851,8 @@ struct xfs_qm_isolate { > * started afresh by xfs_qm_quotacheck. > */ > #ifdef DEBUG > - j = XFS_FSB_TO_B(mp, XFS_DQUOT_CLUSTER_SIZE_FSB); > - do_div(j, sizeof(xfs_dqblk_t)); > + j = (int)XFS_FSB_TO_B(mp, XFS_DQUOT_CLUSTER_SIZE_FSB) / > + sizeof(xfs_dqblk_t); > ASSERT(mp->m_quotainfo->qi_dqperchunk == j); > #endif > dqb = bp->b_addr; > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html