From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Jorgen S. Hansen" <jhansen@vmware.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Zhu Yanjun <zyjzyj2000@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Gerard Garcia <ggarcia@abra.uab.cat>
Subject: Re: [PATCH v4 1/3] VSOCK: Add vsockmon tap functions
Date: Thu, 20 Apr 2017 15:24:27 +0100 [thread overview]
Message-ID: <20170420142427.GB28450@stefanha-x1.localdomain> (raw)
In-Reply-To: <F612F48C-8072-4588-B38A-2F366F53040A@vmware.com>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
On Thu, Apr 20, 2017 at 12:27:37PM +0000, Jorgen S. Hansen wrote:
>
> > On Apr 13, 2017, at 6:18 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > +
> > +static void __vsock_deliver_tap(struct sk_buff *skb)
> > +{
> > + int ret;
> > + struct vsock_tap *tmp;
> > +
> > + list_for_each_entry_rcu(tmp, &vsock_tap_all, list) {
> > + ret = __vsock_deliver_tap_skb(skb, tmp->dev);
> > + if (unlikely(ret))
> > + break;
> > + }
> > +
> > + consume_skb(skb);
>
> It looks like the caller will allocate the skb regardless of whether vsock_tap_all is empty, so shouldn’t the skb be consumed in vsock_deliver_tap?
You are right. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-04-20 14:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 16:18 [PATCH v4 0/3] VSOCK: vsockmon virtual device to monitor AF_VSOCK sockets Stefan Hajnoczi
2017-04-13 16:18 ` [PATCH v4 1/3] VSOCK: Add vsockmon tap functions Stefan Hajnoczi
2017-04-20 12:27 ` Jorgen S. Hansen
2017-04-20 14:24 ` Stefan Hajnoczi [this message]
2017-04-13 16:18 ` [PATCH v4 2/3] VSOCK: Add vsockmon device Stefan Hajnoczi
2017-04-13 16:18 ` [PATCH v4 3/3] VSOCK: Add virtio vsock vsockmon hooks Stefan Hajnoczi
2017-04-13 18:47 ` Michael S. Tsirkin
2017-04-20 10:32 ` Stefan Hajnoczi
2017-04-20 12:35 ` Jorgen S. Hansen
2017-04-20 14:24 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420142427.GB28450@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=ggarcia@abra.uab.cat \
--cc=jhansen@vmware.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.