Re: [PATCH] t6500: don't run detached auto gc at the end of the test script

From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Stefan Beller <sbeller@google.com>, Johannes Sixt <j6t@kdbg.org>,
	Junio C Hamano <gitster@pobox.com>,
	David Turner <dturner@twosigma.com>,
	Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] t6500: don't run detached auto gc at the end of the test script
Date: Thu, 20 Apr 2017 12:45:36 -0400	[thread overview]
Message-ID: <20170420164536.mcbmgfzhsrjqi24f@sigill.intra.peff.net> (raw)
In-Reply-To: <CAM0VKjm1m4v9vTpwFEejBuD3NuGm+kAdEV-_rzCXCz2G4m5NGw@mail.gmail.com>

On Thu, Apr 20, 2017 at 06:42:59PM +0200, SZEDER Gábor wrote:

> > I suppose so. It might be worth being picky just on the principle that
> > if it _is_ gone that's unexpected and we'd prefer somebody notice and
> > figure out why.
> 
> OK, agreed.
> 
> However, we do need the above 'test -d' for this to work, because 'rm
> -rf' doesn't consider non-existing paths as errors, so we wouldn't
> notice that the trash directory is already gone.

Right, that makes sense.

> >> > Replacing it the "exit 1" with a "die" that has a message is probably a
> >> > good idea, though.
> 
> test-lib.sh has a special 'die', different from git-sh-setup.sh's
> 'die'.  I'll use 'error "uh-oh"' instead.

Yeah, sorry, error() is the right function in this instance.

-Peff