From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1039066AbdDUMGO (ORCPT ); Fri, 21 Apr 2017 08:06:14 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:33776 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1039051AbdDUMGJ (ORCPT ); Fri, 21 Apr 2017 08:06:09 -0400 From: Michal Hocko To: linux-mm@kvack.org Cc: Andrew Morton , Mel Gorman , Vlastimil Babka , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Michal Hocko , Yasuaki Ishimatsu Subject: [PATCH 02/13] mm, memory_hotplug: use node instead of zone in can_online_high_movable Date: Fri, 21 Apr 2017 14:05:05 +0200 Message-Id: <20170421120512.23960-3-mhocko@kernel.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170421120512.23960-1-mhocko@kernel.org> References: <20170421120512.23960-1-mhocko@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Hocko the primary purpose of this helper is to query the node state so use the node id directly. This is a preparatory patch for later changes. This shouldn't introduce any functional change Acked-by: Vlastimil Babka Reviewed-by: Yasuaki Ishimatsu Signed-off-by: Michal Hocko --- mm/memory_hotplug.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index b93c88125766..6b6362819be2 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -941,15 +941,15 @@ static int online_pages_range(unsigned long start_pfn, unsigned long nr_pages, * When CONFIG_MOVABLE_NODE, we permit onlining of a node which doesn't have * normal memory. */ -static bool can_online_high_movable(struct zone *zone) +static bool can_online_high_movable(int nid) { return true; } #else /* CONFIG_MOVABLE_NODE */ /* ensure every online node has NORMAL memory */ -static bool can_online_high_movable(struct zone *zone) +static bool can_online_high_movable(int nid) { - return node_state(zone_to_nid(zone), N_NORMAL_MEMORY); + return node_state(nid, N_NORMAL_MEMORY); } #endif /* CONFIG_MOVABLE_NODE */ @@ -1083,7 +1083,7 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ if ((zone_idx(zone) > ZONE_NORMAL || online_type == MMOP_ONLINE_MOVABLE) && - !can_online_high_movable(zone)) + !can_online_high_movable(pfn_to_nid(pfn))) return -EINVAL; if (online_type == MMOP_ONLINE_KERNEL) { -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f197.google.com (mail-io0-f197.google.com [209.85.223.197]) by kanga.kvack.org (Postfix) with ESMTP id 43DE26B039F for ; Fri, 21 Apr 2017 08:06:05 -0400 (EDT) Received: by mail-io0-f197.google.com with SMTP id l196so127868439ioe.19 for ; Fri, 21 Apr 2017 05:06:05 -0700 (PDT) Received: from mail-io0-f196.google.com (mail-io0-f196.google.com. [209.85.223.196]) by mx.google.com with ESMTPS id f9si1853201ite.78.2017.04.21.05.06.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Apr 2017 05:06:04 -0700 (PDT) Received: by mail-io0-f196.google.com with SMTP id h41so29672298ioi.1 for ; Fri, 21 Apr 2017 05:06:04 -0700 (PDT) From: Michal Hocko Subject: [PATCH 02/13] mm, memory_hotplug: use node instead of zone in can_online_high_movable Date: Fri, 21 Apr 2017 14:05:05 +0200 Message-Id: <20170421120512.23960-3-mhocko@kernel.org> In-Reply-To: <20170421120512.23960-1-mhocko@kernel.org> References: <20170421120512.23960-1-mhocko@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: linux-mm@kvack.org Cc: Andrew Morton , Mel Gorman , Vlastimil Babka , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Michal Hocko , Yasuaki Ishimatsu From: Michal Hocko the primary purpose of this helper is to query the node state so use the node id directly. This is a preparatory patch for later changes. This shouldn't introduce any functional change Acked-by: Vlastimil Babka Reviewed-by: Yasuaki Ishimatsu Signed-off-by: Michal Hocko --- mm/memory_hotplug.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index b93c88125766..6b6362819be2 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -941,15 +941,15 @@ static int online_pages_range(unsigned long start_pfn, unsigned long nr_pages, * When CONFIG_MOVABLE_NODE, we permit onlining of a node which doesn't have * normal memory. */ -static bool can_online_high_movable(struct zone *zone) +static bool can_online_high_movable(int nid) { return true; } #else /* CONFIG_MOVABLE_NODE */ /* ensure every online node has NORMAL memory */ -static bool can_online_high_movable(struct zone *zone) +static bool can_online_high_movable(int nid) { - return node_state(zone_to_nid(zone), N_NORMAL_MEMORY); + return node_state(nid, N_NORMAL_MEMORY); } #endif /* CONFIG_MOVABLE_NODE */ @@ -1083,7 +1083,7 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ if ((zone_idx(zone) > ZONE_NORMAL || online_type == MMOP_ONLINE_MOVABLE) && - !can_online_high_movable(zone)) + !can_online_high_movable(pfn_to_nid(pfn))) return -EINVAL; if (online_type == MMOP_ONLINE_KERNEL) { -- 2.11.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org