From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1165496AbdDXG0N (ORCPT ); Mon, 24 Apr 2017 02:26:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60124 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1165413AbdDXGZp (ORCPT ); Mon, 24 Apr 2017 02:25:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 409521555E Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 409521555E From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org Cc: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Daniel Vetter , Pekka Paalanen , Ilia Mirkin , =?UTF-8?q?Michel=20D=C3=A4nzer?= , Alex Deucher , amd-gfx@lists.freedesktop.org, Jani Nikula , Sean Paul , David Airlie , Gerd Hoffmann , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format Date: Mon, 24 Apr 2017 08:25:29 +0200 Message-Id: <20170424062532.26722-4-kraxel@redhat.com> In-Reply-To: <20170424062532.26722-1-kraxel@redhat.com> References: <20170424062532.26722-1-kraxel@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 24 Apr 2017 06:25:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return correct fourcc codes on bigendian. Drivers must be adapted to this change. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/drm_fourcc.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index adb3ff59a4..28401d3745 100644 --- a/drivers/gpu/drm/drm_fourcc.c +++ b/drivers/gpu/drm/drm_fourcc.c @@ -42,11 +42,34 @@ static char printable_char(int c) * * Computes a drm fourcc pixel format code for the given @bpp/@depth values. * Useful in fbdev emulation code, since that deals in those values. + * + * DRM_FORMAT_* are little endian, we'll pick cpu endian here, therefore we + * results differ depending on byte order. */ uint32_t drm_mode_legacy_fb_format(uint32_t bpp, uint32_t depth) { uint32_t fmt; +#ifdef __BIG_ENDIAN + switch (bpp) { + case 8: + fmt = DRM_FORMAT_C8; + break; + case 24: + fmt = DRM_FORMAT_BGR888; + break; + case 32: + if (depth == 24) + fmt = DRM_FORMAT_BGRX8888; + else + fmt = DRM_FORMAT_BGRA8888; + break; + default: + DRM_ERROR("bad bpp, assuming b8g8r8x8 pixel format\n"); + fmt = DRM_FORMAT_BGRX8888; + break; + } +#else switch (bpp) { case 8: fmt = DRM_FORMAT_C8; @@ -73,6 +96,7 @@ uint32_t drm_mode_legacy_fb_format(uint32_t bpp, uint32_t depth) fmt = DRM_FORMAT_XRGB8888; break; } +#endif return fmt; } -- 2.9.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format Date: Mon, 24 Apr 2017 08:25:29 +0200 Message-ID: <20170424062532.26722-4-kraxel@redhat.com> References: <20170424062532.26722-1-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170424062532.26722-1-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: =?UTF-8?q?Michel=20D=C3=A4nzer?= , open list , amd-gfx@lists.freedesktop.org, Daniel Vetter , Gerd Hoffmann List-Id: dri-devel@lists.freedesktop.org UmV0dXJuIGNvcnJlY3QgZm91cmNjIGNvZGVzIG9uIGJpZ2VuZGlhbi4gIERyaXZlcnMgbXVzdCBi ZSBhZGFwdGVkIHRvCnRoaXMgY2hhbmdlLgoKU2lnbmVkLW9mZi1ieTogR2VyZCBIb2ZmbWFubiA8 a3JheGVsQHJlZGhhdC5jb20+Ci0tLQogZHJpdmVycy9ncHUvZHJtL2RybV9mb3VyY2MuYyB8IDI0 ICsrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMo KykKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jIGIvZHJpdmVycy9n cHUvZHJtL2RybV9mb3VyY2MuYwppbmRleCBhZGIzZmY1OWE0Li4yODQwMWQzNzQ1IDEwMDY0NAot LS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fZm91cmNjLmMKQEAgLTQyLDExICs0MiwzNCBAQCBzdGF0aWMgY2hhciBwcmludGFibGVfY2hh cihpbnQgYykKICAqCiAgKiBDb21wdXRlcyBhIGRybSBmb3VyY2MgcGl4ZWwgZm9ybWF0IGNvZGUg Zm9yIHRoZSBnaXZlbiBAYnBwL0BkZXB0aCB2YWx1ZXMuCiAgKiBVc2VmdWwgaW4gZmJkZXYgZW11 bGF0aW9uIGNvZGUsIHNpbmNlIHRoYXQgZGVhbHMgaW4gdGhvc2UgdmFsdWVzLgorICoKKyAqIERS TV9GT1JNQVRfKiBhcmUgbGl0dGxlIGVuZGlhbiwgd2UnbGwgcGljayBjcHUgZW5kaWFuIGhlcmUs IHRoZXJlZm9yZSB3ZQorICogcmVzdWx0cyBkaWZmZXIgZGVwZW5kaW5nIG9uIGJ5dGUgb3JkZXIu CiAgKi8KIHVpbnQzMl90IGRybV9tb2RlX2xlZ2FjeV9mYl9mb3JtYXQodWludDMyX3QgYnBwLCB1 aW50MzJfdCBkZXB0aCkKIHsKIAl1aW50MzJfdCBmbXQ7CiAKKyNpZmRlZiBfX0JJR19FTkRJQU4K Kwlzd2l0Y2ggKGJwcCkgeworCWNhc2UgODoKKwkJZm10ID0gRFJNX0ZPUk1BVF9DODsKKwkJYnJl YWs7CisJY2FzZSAyNDoKKwkJZm10ID0gRFJNX0ZPUk1BVF9CR1I4ODg7CisJCWJyZWFrOworCWNh c2UgMzI6CisJCWlmIChkZXB0aCA9PSAyNCkKKwkJCWZtdCA9IERSTV9GT1JNQVRfQkdSWDg4ODg7 CisJCWVsc2UKKwkJCWZtdCA9IERSTV9GT1JNQVRfQkdSQTg4ODg7CisJCWJyZWFrOworCWRlZmF1 bHQ6CisJCURSTV9FUlJPUigiYmFkIGJwcCwgYXNzdW1pbmcgYjhnOHI4eDggcGl4ZWwgZm9ybWF0 XG4iKTsKKwkJZm10ID0gRFJNX0ZPUk1BVF9CR1JYODg4ODsKKwkJYnJlYWs7CisJfQorI2Vsc2UK IAlzd2l0Y2ggKGJwcCkgewogCWNhc2UgODoKIAkJZm10ID0gRFJNX0ZPUk1BVF9DODsKQEAgLTcz LDYgKzk2LDcgQEAgdWludDMyX3QgZHJtX21vZGVfbGVnYWN5X2ZiX2Zvcm1hdCh1aW50MzJfdCBi cHAsIHVpbnQzMl90IGRlcHRoKQogCQlmbXQgPSBEUk1fRk9STUFUX1hSR0I4ODg4OwogCQlicmVh azsKIAl9CisjZW5kaWYKIAogCXJldHVybiBmbXQ7CiB9Ci0tIAoyLjkuMwoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==