From: Lee Jones <lee.jones@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-gpio@vger.kernel.org, platform-driver-x86@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v4] mfd: intel_soc_pmic: Fix a mess with compilation units
Date: Mon, 24 Apr 2017 11:48:51 +0100 [thread overview]
Message-ID: <20170424104851.vuxrg2vuw5ltkp5n@dell> (raw)
In-Reply-To: <1492520724.24567.59.camel@linux.intel.com>
On Tue, 18 Apr 2017, Andy Shevchenko wrote:
> On Tue, 2017-04-11 at 14:54 +0100, Lee Jones wrote:
> > On Tue, 04 Apr 2017, Andy Shevchenko wrote:
> >
> > > Crystal Cove and Whiskey Cove are two different PMICs which are
> > > installed on Intel Atom SoC based platforms.
> > >
> > > Moreover there are two independent drivers that by some reason were
> > > supposed (*) to get into one kernel module.
> > >
> > > Fix the mess by clarifying Kconfig option for Crystal Cove and split
> > > Whiskey Cove out of it.
> > >
> > > (*) It looks like the configuration was never tested with
> > > INTEL_SOC_PMIC=n. The line in Makefile is actually wrong.
> > >
> > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> (supporter:ACPI)
> > > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > > Acked-by: Zhang Rui <rui.zhang@intel.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > - fix dependency for now, proper fix is to provide headers in
> > > platform_data/x86
> > > - add tags
> > > drivers/acpi/Kconfig | 2 +-
> > > drivers/gpio/Kconfig | 2 +-
> > > drivers/mfd/Kconfig | 15 +++++++++++++--
> > > drivers/mfd/Makefile | 2 +-
> > > drivers/platform/x86/Kconfig | 2 +-
> > > drivers/thermal/Kconfig | 2 +-
> > > 6 files changed, 18 insertions(+), 7 deletions(-)
> >
> > Applied, thanks.
>
> I didn't see it in next. Does it cause build issues still? I didn't get
> any report on it.
It's there now.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2017-04-24 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 12:38 [PATCH v4] mfd: intel_soc_pmic: Fix a mess with compilation units Andy Shevchenko
2017-04-11 13:54 ` Lee Jones
2017-04-18 13:05 ` Andy Shevchenko
2017-04-24 10:48 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424104851.vuxrg2vuw5ltkp5n@dell \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.