All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Liam Beguin <liambeguin@gmail.com>
Cc: git@vger.kernel.org, martin.von.zweigbergk@gmail.com
Subject: Re: [PATCH] rebase -i: add config to abbreviate command name
Date: Mon, 24 Apr 2017 08:29:11 -0400	[thread overview]
Message-ID: <20170424122911.5mvftamplokwctbr@sigill.intra.peff.net> (raw)
In-Reply-To: <20170424032347.10878-1-liambeguin@gmail.com>

On Sun, Apr 23, 2017 at 11:23:47PM -0400, Liam Beguin wrote:

> Add the 'rebase.abbrevCmd' boolean config option to allow
> the user to abbreviate the default command name while editing
> the 'git-rebase-todo' file.

Just reading this, I was confused about what the patch actually did.
Reading the code, I figured it out, but perhaps an example would make
sense. Like:

  This means that we will print:

    p 1234abcd subject line

  in the todo file rather than:

    pick 1234abcd subject line

And then of course that left me wondering why somebody would want to do
that. I understand wanting to _type_ the abbreviated version, but surely
it's not too much work to read the full word?

Then I saw:

> ---
> Notes:
> 
>  *  This allows the lines to remain aligned when using single
>     letter commands.

That makes some sense. it should probably be part of the commit message,
so that future readers of "git log" understand why the change was made.

> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 475e874d5155..59b64832aeb4 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -2614,6 +2614,9 @@ rebase.instructionFormat::
>  	the instruction list during an interactive rebase.  The format will automatically
>  	have the long commit hash prepended to the format.
>  
> +rebase.abbrevCmd::
> +	If set to true, abbreviate command name in interactive mode.

Similar to the commit message, this might need to go into more detail.
It was not immediately obvious to me that "command name" means the
command-names in the instruction list.

-Peff

  parent reply	other threads:[~2017-04-24 12:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24  3:23 [PATCH] rebase -i: add config to abbreviate command name Liam Beguin
2017-04-24 10:26 ` Johannes Schindelin
2017-04-24 11:04   ` liam BEGUIN
2017-04-25  2:57   ` liam BEGUIN
2017-04-25 19:45     ` Johannes Schindelin
2017-04-25 22:58       ` liam BEGUIN
2017-04-24 12:29 ` Jeff King [this message]
2017-04-25  4:37 ` [PATCH v2] rebase -i: add config to abbreviate command-names Liam Beguin
2017-04-25  6:29   ` Junio C Hamano
2017-04-25  8:29     ` Jacob Keller
2017-04-25 23:34       ` liam Beguin
2017-04-26  2:09       ` Junio C Hamano
2017-04-25  9:57   ` Andreas Schwab
2017-04-25 13:59     ` Mike Rappazzo
2017-04-25 10:34   ` Philip Oakley
2017-04-25  4:43 ` Liam Beguin
2017-04-25  9:53   ` Andreas Schwab
2017-04-25 21:23     ` Johannes Schindelin
2017-04-25 22:56       ` liam BEGUIN
2017-04-25 20:08   ` Johannes Schindelin
2017-04-26  0:13     ` liam Beguin
2017-04-26  1:47       ` Jeff King
2017-04-26  3:59         ` Junio C Hamano
2017-04-26  9:25           ` Johannes Schindelin
2017-04-27  0:37             ` Junio C Hamano
2017-04-26  9:28       ` Johannes Schindelin
2017-04-26 15:24   ` Ævar Arnfjörð Bjarmason
2017-04-27  1:20     ` liam Beguin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170424122911.5mvftamplokwctbr@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=liambeguin@gmail.com \
    --cc=martin.von.zweigbergk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.