From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1171647AbdDXNgu (ORCPT ); Mon, 24 Apr 2017 09:36:50 -0400 Received: from foss.arm.com ([217.140.101.70]:57074 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1171615AbdDXNgZ (ORCPT ); Mon, 24 Apr 2017 09:36:25 -0400 Date: Mon, 24 Apr 2017 14:36:23 +0100 From: Will Deacon To: Adam Wallis Cc: Yury Norov , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Peter Zijlstra , Catalin Marinas , Jan Glauber , Ingo Molnar , jason.low2@hp.com Subject: Re: [RFC PATCH 0/3] arm64: queued spinlocks and rw-locks Message-ID: <20170424133622.GB12323@arm.com> References: <1491860104-4103-1-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 12, 2017 at 01:04:55PM -0400, Adam Wallis wrote: > On 4/10/2017 5:35 PM, Yury Norov wrote: > > The patch of Jan Glauber enables queued spinlocks on arm64. I rebased it on > > latest kernel sources, and added a couple of fixes to headers to apply it > > smoothly. > > > > Though, locktourture test shows significant performance degradation in the > > acquisition of rw-lock for read on qemu: > > > > Before After > > spin_lock-torture: 38957034 37076367 -4.83 > > rw_lock-torture W: 5369471 18971957 253.33 > > rw_lock-torture R: 6413179 3668160 -42.80 > > > > On our 48 core QDF2400 part, I am seeing huge improvements with these patches on > the torture tests. The improvements go up even further when I apply Jason Low's > MCS Spinlock patch: https://lkml.org/lkml/2016/4/20/725 Does the QDF2400 implement the large system extensions? If so, how do the queued lock implementations compare to the LSE-based ticket locks? Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Mon, 24 Apr 2017 14:36:23 +0100 Subject: [RFC PATCH 0/3] arm64: queued spinlocks and rw-locks In-Reply-To: References: <1491860104-4103-1-git-send-email-ynorov@caviumnetworks.com> Message-ID: <20170424133622.GB12323@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Apr 12, 2017 at 01:04:55PM -0400, Adam Wallis wrote: > On 4/10/2017 5:35 PM, Yury Norov wrote: > > The patch of Jan Glauber enables queued spinlocks on arm64. I rebased it on > > latest kernel sources, and added a couple of fixes to headers to apply it > > smoothly. > > > > Though, locktourture test shows significant performance degradation in the > > acquisition of rw-lock for read on qemu: > > > > Before After > > spin_lock-torture: 38957034 37076367 -4.83 > > rw_lock-torture W: 5369471 18971957 253.33 > > rw_lock-torture R: 6413179 3668160 -42.80 > > > > On our 48 core QDF2400 part, I am seeing huge improvements with these patches on > the torture tests. The improvements go up even further when I apply Jason Low's > MCS Spinlock patch: https://lkml.org/lkml/2016/4/20/725 Does the QDF2400 implement the large system extensions? If so, how do the queued lock implementations compare to the LSE-based ticket locks? Will