From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [PATCH v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function Date: Mon, 24 Apr 2017 18:46:12 +0300 Message-ID: <20170424154612.GA2229@yuval-lap> References: <1489500117-7937-1-git-send-email-yuval.shaia@oracle.com> <20170314175843.GY2079@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170314175843.GY2079-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: benve-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org, dgoodell-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tue, Mar 14, 2017 at 07:58:43PM +0200, Leon Romanovsky wrote: > On Tue, Mar 14, 2017 at 04:01:57PM +0200, Yuval Shaia wrote: > > This logic seems to be duplicated in (at least) three separate files. > > Move it to one place so code can be re-use. > > > > Signed-off-by: Yuval Shaia > > --- > > v0 -> v1: > > * Add missing #include > > * Rename to genaddrconf_ifid_eui48 > > v1 -> v2: > > * Reset eui[0] to default if dev_id is used > > v2 -> v3: > > * Add helper function to avoid re-setting eui[0] to default if > > dev_id is used > > v3 -> v4: > > * Remove RXE wrappers > > * Remove addrconf_addr_eui48_xor and do the eui[0] ^= 2 in the > > basic implementation > > --- > > drivers/infiniband/hw/usnic/usnic_common_util.h | 11 +++------- > > drivers/infiniband/sw/rxe/rxe.c | 4 +++- > > drivers/infiniband/sw/rxe/rxe_loc.h | 2 -- > > drivers/infiniband/sw/rxe/rxe_net.c | 28 ------------------------- > > drivers/infiniband/sw/rxe/rxe_verbs.c | 4 +++- > > include/net/addrconf.h | 22 +++++++++++++++---- > > 6 files changed, 27 insertions(+), 44 deletions(-) > > > > Thanks, Yuval. > Reviewed-by: Leon Romanovsky Hi Doug, If no more comments on this one can you consider taking it? Thanks, Yuval -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [PATCH v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function Date: Mon, 24 Apr 2017 18:46:12 +0300 Message-ID: <20170424154612.GA2229@yuval-lap> References: <1489500117-7937-1-git-send-email-yuval.shaia@oracle.com> <20170314175843.GY2079@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: benve-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org, dgoodell-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Return-path: Content-Disposition: inline In-Reply-To: <20170314175843.GY2079-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Tue, Mar 14, 2017 at 07:58:43PM +0200, Leon Romanovsky wrote: > On Tue, Mar 14, 2017 at 04:01:57PM +0200, Yuval Shaia wrote: > > This logic seems to be duplicated in (at least) three separate files. > > Move it to one place so code can be re-use. > > > > Signed-off-by: Yuval Shaia > > --- > > v0 -> v1: > > * Add missing #include > > * Rename to genaddrconf_ifid_eui48 > > v1 -> v2: > > * Reset eui[0] to default if dev_id is used > > v2 -> v3: > > * Add helper function to avoid re-setting eui[0] to default if > > dev_id is used > > v3 -> v4: > > * Remove RXE wrappers > > * Remove addrconf_addr_eui48_xor and do the eui[0] ^= 2 in the > > basic implementation > > --- > > drivers/infiniband/hw/usnic/usnic_common_util.h | 11 +++------- > > drivers/infiniband/sw/rxe/rxe.c | 4 +++- > > drivers/infiniband/sw/rxe/rxe_loc.h | 2 -- > > drivers/infiniband/sw/rxe/rxe_net.c | 28 ------------------------- > > drivers/infiniband/sw/rxe/rxe_verbs.c | 4 +++- > > include/net/addrconf.h | 22 +++++++++++++++---- > > 6 files changed, 27 insertions(+), 44 deletions(-) > > > > Thanks, Yuval. > Reviewed-by: Leon Romanovsky Hi Doug, If no more comments on this one can you consider taking it? Thanks, Yuval -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html