From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1430471AbdDYTKg (ORCPT ); Tue, 25 Apr 2017 15:10:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43670 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941209AbdDYTK3 (ORCPT ); Tue, 25 Apr 2017 15:10:29 -0400 Date: Tue, 25 Apr 2017 21:10:19 +0200 From: Greg Kroah-Hartman To: Ilia Sergachev Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ks7010: fix few checkpatch warnings in ks_wlan_net.c Message-ID: <20170425191019.GA27234@kroah.com> References: <20170425190248.6041-1-BM-2cVwRgNYPK72fLRfbWfkkmYLu7qHhYpwtr@bitmessage.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170425190248.6041-1-BM-2cVwRgNYPK72fLRfbWfkkmYLu7qHhYpwtr@bitmessage.ch> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 25, 2017 at 09:02:48PM +0200, Ilia Sergachev wrote: > Fixes few warnings and checks in drivers/staging/ks7010/ks_wlan_net.c What type of warnings? What checks? It builds just fine for me here. You need to be very specific. And only do one type of thing per patch, a big "fixes all types of warnings" is not ok in a single patch. > > Signed-off-by: Ilia Sergachev > Cc: devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org That last line doesn't make much sense, does it? thanks, greg k-h