From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [oss-drivers] Re: [RFC 3/4] nfp: make use of extended ack message reporting Date: Wed, 26 Apr 2017 10:44:16 -0400 (EDT) Message-ID: <20170426.104416.270999555163740292.davem@davemloft.net> References: <9765d004-de19-7cf2-fcfc-1d2e72cded43@mojatatu.com> <20170425.102022.219410555949403896.davem@davemloft.net> <20170426111315.GC28251@vergenet.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jhs@mojatatu.com, jakub.kicinski@netronome.com, netdev@vger.kernel.org, johannes@sipsolutions.net, dsa@cumulusnetworks.com, daniel@iogearbox.net, alexei.starovoitov@gmail.com, bblanco@gmail.com, john.fastabend@gmail.com, kubakici@wp.pl, oss-drivers@netronome.com To: simon.horman@netronome.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:55890 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1434638AbdDZOoT (ORCPT ); Wed, 26 Apr 2017 10:44:19 -0400 In-Reply-To: <20170426111315.GC28251@vergenet.net> Sender: netdev-owner@vger.kernel.org List-ID: From: Simon Horman Date: Wed, 26 Apr 2017 13:13:16 +0200 > On Tue, Apr 25, 2017 at 10:20:22AM -0400, David Miller wrote: >> From: Jamal Hadi Salim >> Date: Tue, 25 Apr 2017 08:42:32 -0400 >> >> > So are we going to standardize these strings? >> >> No. >> >> > i.e what if some user has written a bash script that depends on this >> > string and it gets changed later. >> >> They can't do that. >> >> It's free form extra information an application may or not provide >> to the user when the kernel emits it. > > I don't feel strongly about this and perhaps it can be revisited at some > point but perhaps it would be worth documenting that he strings do not > form part of the UAPI as my expectation would have been that they do f.e. to > facilitate internationalisation. These two things are entirely separate. We can maintain uptodate translations of the strings, yet document that they can change at any time and are thus not UAPI.